[Submission]: It provides additional functionality for connecting to containers and accessing them using fixed domain names.

[ytcheng]

Docker Hub repository name

ytcheng/desktop-connector

Terms of services

• [X] I accept the term of services

[github-actions[bot]]

:white_check_mark: @ytcheng has accepted the terms of service.

The automatic validation of your extension has started, you will see the result in ~10 minutes :hourglass_flowing_sand:.

[github-actions[bot]]

:x: Validation failed with the following errors

Pulled imageChecked image labels(required) image label "com.docker.extension.screenshots" has an empty alternative text at JSON item 0: https://docs.docker.com/desktop/extensions-sdk/extensions/labels/ (required) image label "com.docker.extension.screenshots" has an empty alternative text at JSON item 1: https://docs.docker.com/desktop/extensions-sdk/extensions/labels/ Checked metadata.jsonChecked image tag is semverChecked image is multiplatformChecked extension is compatible with current SDK versionInstalled extension successfullyRemoved extension successfullyThe extension "ytcheng/desktop-connector:0.0.2" hasn't passed the checks to be published.

Please fix the issues and check everything is ok locally with the following command:

docker extension validate -a -s -i ytcheng/desktop-connector

Then you can trigger the validation commenting /validate when you are ready.

See https://docs.docker.com/desktop/extensions-sdk/extensions/validate/ for more information.

[ytcheng]

/validate

[github-actions[bot]]

:white_check_mark: The extension ytcheng/desktop-connector is valid :tada:.

Now, @docker/extensions will authorise the publication of the extension to the marketplace. Once the extension is published, this issue will be closed.

In the meantime, please tell us about your experience building a Docker Desktop extension here: https://survey.alchemer.com/s3/7184948/Publishers-Feedback-Form.

[benja-M-1]

Hi @ytcheng I see that the extension is very similar to https://open.docker.com/extensions/marketplace?extensionId=tailscale/docker-extension. Is it intended?

[ytcheng]

I modified it based on tailscale/docker-extension and added some features.

[benja-M-1]

May I suggest to submit PRs to their repo then? https://github.com/tailscale/docker-extension

[ytcheng]

I believe tailscale/docker-extension has a specific focus in their product line, and they may not accept my PR. The main purpose of my extension is to enable direct connectivity between Docker Desktop and containers.

[benja-M-1]

I might be wrong but, the way I understand "direct connectivity between Docker Desktop and containers" is exactly the purpose of Tailscale's extension :) I can ask them if they are open to PR to add some features in the extension if you want. Would that be ok for you?

My main concern is that users get confused because there are two similar Tailscale extensions. And they might trust more and thus prefer to use the one created by Tailscale themselves.

[rosszurowski]

Hi @ytcheng! Ross from Tailscale here.

I chatted with the team. While it'd be nice to add these features to the official tailscale extension, we don't have a ton of capacity at the moment to make or review those changes. I also suspect if we implemented those features (container-to-container connection, custom magicdns domains per container), they would look substantially different from what you've built today too, and it'd be unfair to ask you to do that work.

With that in mind, I think we'd be comfortable with you publishing this extension as long as it's really clear to users that it's an unofficial extension and isn't supported by Tailscale. The custom icon and name is a good start, but would you mind making these changes to further distinguish it?

• Not using the Tailscale logo anywhere
• Changing the Docker Extension marketplace language to be a little different. Currently they're quite similar.
  • Desktop Connector: “With the Desktop Connector, you can create a secure virtual private network and connect your containers to it within minutes. Any containers with exposed ports are accessible to other devices on the Tailscale network.”
  • Tailscale: “With Tailscale, create a secure, virtual private network to connect your devices to in minutes. Tailscale’s Docker Desktop extension enables you to connect your containers to your Tailscale network.”
• Changing the onboarding text to be different from Tailscale's:
  • The “Share exposed container ports onto your private Tailscale network…” is currently the same as the Tailscale extension
  • The “New to Tailscale?” text implies it’s part of Tailscale.
  • The “learn how Tailscale works … in our docs” which implies it’s made by Tailscale
• Changing the log out language to not say “Logging out of Tailscale” but instead “Logging out of Desktop Connector.”
• Removing “Tailscale” title from the top-left of the main screen”
• Use its own “open source licenses” link (since it also references other OSS software not included in that list)

Generally, just forking it a little further so no one confuses the two extensions. It seems like it's a big list, but it's mostly just language changes, and hopefully shouldn't take long!

Thanks for your efforts!

[benja-M-1]

Thank you @rosszurowski for jumping in! 👍 I am closing this issue for now. @ytcheng You can create a new one whenever you are ready :)