docker / extensions-submissions

Submit your Docker Extension here
Apache License 2.0
11 stars 2 forks source link

[Submission]: Docker Labs VSCode Installer #156

Closed ColinMcNeil closed 2 months ago

ColinMcNeil commented 5 months ago

Docker Hub repository name

docker/labs-vscode-installer

Terms of services

github-actions[bot] commented 5 months ago

:white_check_mark: @ColinMcNeil has accepted the terms of service.

The automatic validation of your extension has started, you will see the result in ~10 minutes :hourglass_flowing_sand:.

github-actions[bot] commented 5 months ago

:x: Validation failed with the following errors

failed to resolve the greatest semver tag for repo "docker/labs-vscode-installer": repository does not exist or may require 'docker login'

Please fix the issues and check everything is ok locally with the following command:

docker extension validate -a -s -i docker/labs-vscode-installer

Then you can trigger the validation commenting /validate when you are ready.

See https://docs.docker.com/desktop/extensions-sdk/extensions/validate/ for more information.

github-actions[bot] commented 5 months ago

:x: Validation failed with the following errors

no tags with semantic versioning found

Please fix the issues and check everything is ok locally with the following command:

docker extension validate -a -s -i vonwig/labs-vscode-installer

Then you can trigger the validation commenting /validate when you are ready.

See https://docs.docker.com/desktop/extensions-sdk/extensions/validate/ for more information.

ColinMcNeil commented 5 months ago

/validate

github-actions[bot] commented 5 months ago

:x: Validation failed with the following errors

failed to resolve the greatest semver tag for repo "docker/labs-vscode-installer": repository does not exist or may require 'docker login'

Please fix the issues and check everything is ok locally with the following command:

docker extension validate -a -s -i docker/labs-vscode-installer

Then you can trigger the validation commenting /validate when you are ready.

See https://docs.docker.com/desktop/extensions-sdk/extensions/validate/ for more information.

github-actions[bot] commented 5 months ago

:x: Validation failed with the following errors

failed to resolve the greatest semver tag for repo "docker/labs-vscode-installer": repository does not exist or may require 'docker login'

Please fix the issues and check everything is ok locally with the following command:

docker extension validate -a -s -i docker/labs-vscode-installer

Then you can trigger the validation commenting /validate when you are ready.

See https://docs.docker.com/desktop/extensions-sdk/extensions/validate/ for more information.

ColinMcNeil commented 5 months ago

/validate

github-actions[bot] commented 5 months ago

:x: Validation failed with the following errors

no tags with semantic versioning found

Please fix the issues and check everything is ok locally with the following command:

docker extension validate -a -s -i docker/labs-vscode-installer

Then you can trigger the validation commenting /validate when you are ready.

See https://docs.docker.com/desktop/extensions-sdk/extensions/validate/ for more information.

ColinMcNeil commented 5 months ago

/validate

github-actions[bot] commented 5 months ago

:white_check_mark: The extension docker/labs-vscode-installer is valid :tada:.

Now, @docker/extensions will authorise the publication of the extension to the marketplace. Once the extension is published, this issue will be closed.

In the meantime, please tell us about your experience building a Docker Desktop extension here: https://docs.google.com/forms/d/e/1FAIpQLSdruIWGS9Em0p2jVIixQeiVyQJs27EzLA4ks2YzlBZpWUJC2Q/viewform.

gtardif commented 5 months ago

Hi @ColinMcNeil , Thx for submitting this extension! I'm not sure if you really intend to publish this extension to the marketplace: the first thing displayed in the extension main panel is : Disclaimer: extensions are ready for evaluation, but are not ready to enter the public marketplace..

(Nit: just after this it displays code command exists, this probably requires a bit of context or explanation, at the moment it is not clear what the user is supposed to do with this)

gtardif commented 5 months ago

I forgot to mention, BTW, the extension is lacking an icon (the label com.docker.desktop.extension must be a public URL that will get displayed in the marketpace) , and the description shows an invalid image

ColinMcNeil commented 5 months ago

@gtardif Sorry, I have updated to wording in the page to make sure it is clear that the extensions are for VSCode. The basic idea is that this extension is a GUI wrapper for pulling our VSCode extension bundles and running code --install-extension

ColinMcNeil commented 5 months ago

There is no way to bundle the icon and screenshots with the image?

gtardif commented 5 months ago

There is no way to bundle the icon and screenshots with the image?

The extension image is only downloaded upon install ; only the manifest is to build the marketplace info, so the icon/screenshots must be publicly downloadable for the marketplace (note we download screenshots once while consolidating marketplace info, and save screenshots in our own S3 bucket)

ColinMcNeil commented 3 months ago

Sorry for long delay. Logo is added.

gtardif commented 3 months ago

Hi, Thx for the update! Unfortunately, the icon does not show up well in light mode:

Screenshot 2024-07-29 at 12 26 53

Also, in dark mode it is quite small and almost impossible to read the text in the icon ; maybe the icon should be simplified to include less text and be more readable?

And the icon displayed in the marketplace needs to be a public URL (as we dont download the full image to show the marketplace info) ; image label "com.docker.desktop.extension.icon": "./docker.svg" needs to be a public URL for the svg (but still included as a file inside the image as it is today) You can install your extension and check how the extension displays in the marketplace with the menu "Extensions > Manage"

Screenshot 2024-07-29 at 12 30 46
ColinMcNeil commented 2 months ago

Just pushed a new icon with proper contrast on light & darkmode.

publisher-extensions-bot[bot] commented 2 months ago

:tada: Congratulations, your extension has been published to the marketplace.

It may not appear in your Docker Desktop yet. In that case, restart Docker Desktop (don't worry, users will see it as soon as the cache is refreshed, every ~12 hours).

If you haven't already, please tell us about your experience building a Docker Desktop extension here.