docker / extensions-submissions

Submit your Docker Extension here
Apache License 2.0
11 stars 2 forks source link

[Submission]: vishalvivekanandan05/dockular-extension:0.0.1 #157

Closed vishalVivekanandan closed 3 months ago

vishalVivekanandan commented 4 months ago

Docker Hub repository name

vishalvivekanandan05/dockular-extension:0.0.1

Terms of services

github-actions[bot] commented 4 months ago

:white_check_mark: @vishalVivekanandan has accepted the terms of service.

The automatic validation of your extension has started, you will see the result in ~10 minutes :hourglass_flowing_sand:.

github-actions[bot] commented 4 months ago

:white_check_mark: The extension vishalvivekanandan05/my-extension is valid :tada:.

Now, @docker/extensions will authorise the publication of the extension to the marketplace. Once the extension is published, this issue will be closed.

In the meantime, please tell us about your experience building a Docker Desktop extension here: https://docs.google.com/forms/d/e/1FAIpQLSdruIWGS9Em0p2jVIixQeiVyQJs27EzLA4ks2YzlBZpWUJC2Q/viewform.

gtardif commented 3 months ago

Hello @vishalVivekanandan , Thanks for submitting the extension! Looking at the name vishalvivekanandan05/my-extension:0.0.1 you probably want to rename it, to something like vishalvivekanandan05/dockular-extension:0.0.1 ? It's better to fix this naming issue before publishing the extension in the marketplace, otherwise extension users won't get updates after an extension rename. You can edit the issue description and run /validate again

And trying a bit the extension, I noticed that when selecting Prune>Images or Prune>Containers, there's a checkbox for each line that you can select on the right panel. When selecting Prune>Build, the checkbox is missing and I can't select any build cache element.

github-actions[bot] commented 3 months ago

:white_check_mark: The extension vishalvivekanandan05/my-extension is valid :tada:.

Now, @docker/extensions will authorise the publication of the extension to the marketplace. Once the extension is published, this issue will be closed.

In the meantime, please tell us about your experience building a Docker Desktop extension here: https://docs.google.com/forms/d/e/1FAIpQLSdruIWGS9Em0p2jVIixQeiVyQJs27EzLA4ks2YzlBZpWUJC2Q/viewform.

github-actions[bot] commented 3 months ago

:x: Validation failed with the following errors

failed to resolve the greatest semver tag for repo "vishalvivekanandan05/dockular-extension": repository does not exist or may require 'docker login'

Please fix the issues and check everything is ok locally with the following command:

docker extension validate -a -s -i vishalvivekanandan05/dockular-extension

Then you can trigger the validation commenting /validate when you are ready.

See https://docs.docker.com/desktop/extensions-sdk/extensions/validate/ for more information.

github-actions[bot] commented 3 months ago

:x: Validation failed with the following errors

failed to resolve the greatest semver tag for repo "vishalvivekanandan05/dockular-extension": repository does not exist or may require 'docker login'

Please fix the issues and check everything is ok locally with the following command:

docker extension validate -a -s -i vishalvivekanandan05/dockular-extension

Then you can trigger the validation commenting /validate when you are ready.

See https://docs.docker.com/desktop/extensions-sdk/extensions/validate/ for more information.

github-actions[bot] commented 3 months ago

:x: Validation failed with the following errors

failed to resolve the greatest semver tag for repo "vishalvivekanandan05/dockular-extension": repository does not exist or may require 'docker login'

Please fix the issues and check everything is ok locally with the following command:

docker extension validate -a -s -i vishalvivekanandan05/dockular-extension

Then you can trigger the validation commenting /validate when you are ready.

See https://docs.docker.com/desktop/extensions-sdk/extensions/validate/ for more information.

vishalVivekanandan commented 3 months ago

/validate

github-actions[bot] commented 3 months ago

:x: Terms of Service not accepted yet.

@vishalVivekanandan to proceed with the submission of your extension you must accept the term of services.

github-actions[bot] commented 3 months ago

:white_check_mark: @vishalVivekanandan has accepted the terms of service.

The automatic validation of your extension has started, you will see the result in ~10 minutes :hourglass_flowing_sand:.

github-actions[bot] commented 3 months ago

:white_check_mark: @vishalVivekanandan has accepted the terms of service.

The automatic validation of your extension has started, you will see the result in ~10 minutes :hourglass_flowing_sand:.

github-actions[bot] commented 3 months ago

:white_check_mark: The extension vishalvivekanandan05/dockular-extension is valid :tada:.

Now, @docker/extensions will authorise the publication of the extension to the marketplace. Once the extension is published, this issue will be closed.

In the meantime, please tell us about your experience building a Docker Desktop extension here: https://docs.google.com/forms/d/e/1FAIpQLSdruIWGS9Em0p2jVIixQeiVyQJs27EzLA4ks2YzlBZpWUJC2Q/viewform.

github-actions[bot] commented 3 months ago

:white_check_mark: The extension vishalvivekanandan05/dockular-extension is valid :tada:.

Now, @docker/extensions will authorise the publication of the extension to the marketplace. Once the extension is published, this issue will be closed.

In the meantime, please tell us about your experience building a Docker Desktop extension here: https://docs.google.com/forms/d/e/1FAIpQLSdruIWGS9Em0p2jVIixQeiVyQJs27EzLA4ks2YzlBZpWUJC2Q/viewform.

github-actions[bot] commented 3 months ago

:white_check_mark: The extension vishalvivekanandan05/dockular-extension is valid :tada:.

Now, @docker/extensions will authorise the publication of the extension to the marketplace. Once the extension is published, this issue will be closed.

In the meantime, please tell us about your experience building a Docker Desktop extension here: https://docs.google.com/forms/d/e/1FAIpQLSdruIWGS9Em0p2jVIixQeiVyQJs27EzLA4ks2YzlBZpWUJC2Q/viewform.

github-actions[bot] commented 3 months ago

:white_check_mark: The extension vishalvivekanandan05/dockular-extension is valid :tada:.

Now, @docker/extensions will authorise the publication of the extension to the marketplace. Once the extension is published, this issue will be closed.

In the meantime, please tell us about your experience building a Docker Desktop extension here: https://docs.google.com/forms/d/e/1FAIpQLSdruIWGS9Em0p2jVIixQeiVyQJs27EzLA4ks2YzlBZpWUJC2Q/viewform.

vishalVivekanandan commented 3 months ago

Hi @gtardif, hope you're doing well! I've edited the name of the extension as per your suggestions and the validation has passed. Also, I didn’t add the check marks for the build cache because they can’t be pruned the same way compared to containers. It’s implemented this way so they can view the build cache for now. The build cache prune feature is still in beta as per our readme and we hope to get it working soon. Please let me know if you can publish the extension to the marketplace. Thank you!

gtardif commented 3 months ago

Thx for the update @vishalVivekanandan, the extension should be in the marketplace soon 🎉

publisher-extensions-bot[bot] commented 3 months ago

:tada: Congratulations, your extension has been published to the marketplace.

It may not appear in your Docker Desktop yet. In that case, restart Docker Desktop (don't worry, users will see it as soon as the cache is refreshed, every ~12 hours).

If you haven't already, please tell us about your experience building a Docker Desktop extension here.

vishalVivekanandan commented 3 months ago

Hi @gtardif, it looks like our extension is still not on Docker Desktop Marketplace as of now. We're not sure why it's still not appearing, could you let us know if there's anything else we need to do on our end? We're trying to add the extension itself (not the image), but we can't find it on Docker Desktop. Thanks.

vishalVivekanandan commented 3 months ago

Hi @gtardif, I just checked the marketplace and it looks like it's up now. However, I noticed that it says the extension is not reviewed. Is this something that can be addressed? Also, I noticed that the logo doesn't show up on the sidebar when we install the extension. Please let me know if there's anything I can do on my end to resolve these issues. Thanks!

vishalVivekanandan commented 3 months ago

Hi @gtardif, following up regarding the launch of Dockular, I was wondering if you or someone else could manually review our extension so that our extension doesn't appear as unreviewed? If this may be possible, we'd greatly appreciate it thanks!