Closed spurin closed 3 months ago
:white_check_mark: @spurin has accepted the terms of service.
The automatic validation of your extension has started, you will see the result in ~10 minutes :hourglass_flowing_sand:.
:white_check_mark: The extension spurin/diveintokubernetes-introduction-lab-extension is valid :tada:.
Now, @docker/extensions will authorise the publication of the extension to the marketplace. Once the extension is published, this issue will be closed.
In the meantime, please tell us about your experience building a Docker Desktop extension here: https://docs.google.com/forms/d/e/1FAIpQLSdruIWGS9Em0p2jVIixQeiVyQJs27EzLA4ks2YzlBZpWUJC2Q/viewform.
Ah, sorry I was about to push this to the marketplace and saw that the icon label (com.docker.desktop.extension.icon
) in the image is also giving a 404 ; likely similar to the screenshot issue you fixed.
(Note: no need to reopen a new GH issue here, you can push your new extension version and comment /validate
here)
/validate
:white_check_mark: The extension spurin/diveintokubernetes-introduction-lab-extension is valid :tada:.
Now, @docker/extensions will authorise the publication of the extension to the marketplace. Once the extension is published, this issue will be closed.
In the meantime, please tell us about your experience building a Docker Desktop extension here: https://docs.google.com/forms/d/e/1FAIpQLSdruIWGS9Em0p2jVIixQeiVyQJs27EzLA4ks2YzlBZpWUJC2Q/viewform.
:tada: Congratulations, your extension has been published to the marketplace.
It may not appear in your Docker Desktop yet. In that case, restart Docker Desktop (don't worry, users will see it as soon as the cache is refreshed, every ~12 hours).
If you haven't already, please tell us about your experience building a Docker Desktop extension here.
Hi @spurin, I noticed something weird: this extension has been added in the marketplace but somehow our metadata didn't include the ARM flavor of the extension image. I'm trying to figure out why ; re-running our metadata internal jobs it now sees correctly the 2 platforms of the image (and this is normally validated by the automated job running above).
Just to confirm: you didn't update the image tag after it has been validated here I suppose? I'll fix the extension metadata so that your extension is displayed all right (at the moment it shows 'unsupported' on mac M1s), and I need to figure out why it was wrongly detected at some point, and I can't reproduce this anymore
Hi @gtardif,
Looking through the makefile, possibly, this may have been caused by me. When I updated my Makefile and spun off latest and a semver, I didn't update TAG=
docker buildx build --push --builder=$(BUILDER) --platform=linux/amd64,linux/arm64 --build-arg TAG=latest --tag=$(IMAGE):$(TAG) .
docker buildx build --push --builder=$(BUILDER) --platform=linux/amd64,linux/arm64 --build-arg TAG=latest --tag=$(IMAGE):$(PRODUCTION_TAG) .
Possibly, this is related, is it worthwhile me correcting this, and pushing a minor semver+ for testing purposes?
And to clarify, yes, I did increase the version number, previous was 1.0.1, this version is 1.0.2, sorry, I misread your statement of "push your new extension version" as, update and push a new semver
Thanks, indeed it was already 1.0.2 when this got allowed into the marketplace. (I don't think you need any additional step). Thanks for the info ; this is all fixed on the public marketplace BTW, I'm just trying to investigate if we have some corner case random behaviour I need to fix for a potential next time.
Docker Hub repository name
spurin/diveintokubernetes-introduction-lab-extension
Terms of services