docker / extensions-submissions

Submit your Docker Extension here
Apache License 2.0
11 stars 2 forks source link

[Submission]: KRS (Kubetools Recommendation Service) #172

Closed karanveersingh5623 closed 1 month ago

karanveersingh5623 commented 1 month ago

Docker Hub repository name

kubetoolsca/krs-docker-extension

Terms of services

github-actions[bot] commented 1 month ago

:white_check_mark: @karanveersingh5623 has accepted the terms of service.

The automatic validation of your extension has started, you will see the result in ~10 minutes :hourglass_flowing_sand:.

github-actions[bot] commented 1 month ago

:white_check_mark: The extension kubetoolsca/krs-docker-extension is valid :tada:.

Now, @docker/extensions will authorise the publication of the extension to the marketplace. Once the extension is published, this issue will be closed.

In the meantime, please tell us about your experience building a Docker Desktop extension here: https://docs.google.com/forms/d/e/1FAIpQLSdruIWGS9Em0p2jVIixQeiVyQJs27EzLA4ks2YzlBZpWUJC2Q/viewform.

gtardif commented 1 month ago

Hi @karanveersingh5623, Thx for submitting an extension for Docker Desktop I just noticed that the icon that appears in the extension marketplace does not display properly, you need to check the docker label com.docker.desktop.extension.icon that you set in your Dockerfile (apparently the URL has expired) and provide a valid icon url You'll need to push a 0.0.2 new image to hub, let me know if you have any question

karanveersingh5623 commented 1 month ago

@gtardif We have updated the image to docker hub with 0.0.2 tag https://hub.docker.com/layers/kubetoolsca/krs-docker-extension/0.0.2/images/sha256-e56e2e77e135535bb9e639cf09e3a7b6351761f82488b3f1fd9c79a90debfd43?context=repo

Also we have updated the main branch , kubetoolsca/krs-docker-extension

karanveersingh5623 commented 1 month ago

@gtardif , is there any update on krs extension, let me know if more information needed

gtardif commented 1 month ago

/validate

github-actions[bot] commented 1 month ago

:x: Validation failed with the following errors

0.0.2: Pulling from kubetoolsca/krs-docker-extension 6dce3b49cfe6: Pulling fs layer 8d4dbf8eff6f: Pulling fs layer f5d1f35bbc62: Pulling fs layer 6821d50670bb: Pulling fs layer 083646f0b80d: Pulling fs layer 0bd573872398: Pulling fs layer b50b8f50d0a1: Pulling fs layer 1f7c395817f5: Pulling fs layer ad0ec0b8d60b: Pulling fs layer 2f78869b9518: Pulling fs layer da8c25cb2a35: Pulling fs layer cf8c26766f4c: Pulling fs layer b20757b12ba8: Pulling fs layer 5d2ed121eea0: Pulling fs layer 61b801b1a663: Pulling fs layer 4f4fb700ef54: Pulling fs layer f16bee379211: Pulling fs layer 1f7c395817f5: Waiting 5d2ed121eea0: Waiting ad0ec0b8d60b: Waiting 61b801b1a663: Waiting 2f78869b9518: Waiting 4f4fb700ef54: Waiting da8c25cb2a35: Waiting f16bee379211: Waiting cf8c26766f4c: Waiting b20757b12ba8: Waiting 6821d50670bb: Waiting 083646f0b80d: Waiting 0bd573872398: Waiting b50b8f50d0a1: Waiting 8d4dbf8eff6f: Verifying Checksum 8d4dbf8eff6f: Download complete 6821d50670bb: Verifying Checksum 6821d50670bb: Download complete f5d1f35bbc62: Verifying Checksum f5d1f35bbc62: Download complete 6dce3b49cfe6: Verifying Checksum 6dce3b49cfe6: Download complete 0bd573872398: Verifying Checksum 0bd573872398: Download complete 1f7c395817f5: Verifying Checksum 1f7c395817f5: Download complete b50b8f50d0a1: Verifying Checksum b50b8f50d0a1: Download complete 2f78869b9518: Verifying Checksum 2f78869b9518: Download complete ad0ec0b8d60b: Verifying Checksum ad0ec0b8d60b: Download complete da8c25cb2a35: Verifying Checksum da8c25cb2a35: Download complete cf8c26766f4c: Verifying Checksum cf8c26766f4c: Download complete 6dce3b49cfe6: Pull complete b20757b12ba8: Verifying Checksum b20757b12ba8: Download complete 8d4dbf8eff6f: Pull complete 5d2ed121eea0: Download complete 61b801b1a663: Verifying Checksum 61b801b1a663: Download complete 4f4fb700ef54: Verifying Checksum 4f4fb700ef54: Download complete f16bee379211: Verifying Checksum f16bee379211: Download complete f5d1f35bbc62: Pull complete 6821d50670bb: Pull complete 083646f0b80d: Verifying Checksum 083646f0b80d: Download complete 083646f0b80d: Pull complete 0bd573872398: Pull complete b50b8f50d0a1: Pull complete 1f7c395817f5: Pull complete ad0ec0b8d60b: Pull complete 2f78869b9518: Pull complete da8c25cb2a35: Pull complete cf8c26766f4c: Pull complete b20757b12ba8: Pull complete 5d2ed121eea0: Pull complete 61b801b1a663: Pull complete 4f4fb700ef54: Pull complete f16bee379211: Pull complete Digest: sha256:437ec6624e99397e878de603d868fd258027ed1796d0571f38549712fe0ab57a Status: Downloaded newer image for kubetoolsca/krs-docker-extension:0.0.2 docker.io/kubetoolsca/krs-docker-extension:0.0.2 Pulled imageChecked image labels(required) image label "com.docker.extension.screenshots": URL "https://github.com/kubetoolsca/krs-docker-extension/blob/main/images/image1.png?raw=true" not accessible, status:404: https://docs.docker.com/desktop/extensions-sdk/extensions/labels/ (required) image label "com.docker.extension.screenshots": URL "https://github.com/kubetoolsca/krs-docker-extension/blob/main/images/image2.png?raw=true" not accessible, status:404: https://docs.docker.com/desktop/extensions-sdk/extensions/labels/ Checked metadata.jsonChecked image tag is semverChecked image is multiplatformthe image for platform "linux/arm64" is not pushed to DockerHub: https://docs.docker.com/desktop/extensions-sdk/extensions/multi-arch/Checked extension is compatible with current SDK versionInstalled extension successfullyRemoved extension successfullyThe extension "kubetoolsca/krs-docker-extension:0.0.2" hasn't passed the checks to be published.

Please fix the issues and check everything is ok locally with the following command:

docker extension validate -a -s -i kubetoolsca/krs-docker-extension

Then you can trigger the validation commenting /validate when you are ready.

See https://docs.docker.com/desktop/extensions-sdk/extensions/validate/ for more information.

gtardif commented 1 month ago

Hi @karanveersingh5623, I added /validate comment in order to re-run validation on the latest extension version. It seems you still have a URL pointing to a non valid image

karanveersingh5623 commented 1 month ago

@gtardif , we have updated the image and validated it with 0.0.3 tag . Please check again

https://hub.docker.com/layers/kubetoolsca/krs-docker-extension/0.0.3/images/sha256-b908c6af52a7a33dbbc3b3038264fbf3a8849f05ab5cb87adf4a9c92b0edfb39?context=repo)

Also we have updated the main branch , kubetoolsca/krs-docker-extension

karanveersingh5623 commented 1 month ago

/validate

github-actions[bot] commented 1 month ago

:x: Validation failed with the following errors

0.0.3: Pulling from kubetoolsca/krs-docker-extension 6dce3b49cfe6: Pulling fs layer 8d4dbf8eff6f: Pulling fs layer f5d1f35bbc62: Pulling fs layer 6821d50670bb: Pulling fs layer 1a936d6eb4bb: Pulling fs layer f611c8631b7a: Pulling fs layer 9e69b0752300: Pulling fs layer f5ccc94f7ecd: Pulling fs layer 5ba6280a28b2: Pulling fs layer 7dc32407334f: Pulling fs layer 38d1487ce130: Pulling fs layer b65c1122fe40: Pulling fs layer 9afa5b5e0a08: Pulling fs layer a9da9f0bc52e: Pulling fs layer b96994c5dd4e: Pulling fs layer ff37e87dc2dd: Pulling fs layer 08f8b18f1669: Pulling fs layer 7e7d695302a2: Pulling fs layer f0c9881bb942: Pulling fs layer a9da9f0bc52e: Waiting f5ccc94f7ecd: Waiting b96994c5dd4e: Waiting 5ba6280a28b2: Waiting ff37e87dc2dd: Waiting 7dc32407334f: Waiting 08f8b18f1669: Waiting 38d1487ce130: Waiting b65c1122fe40: Waiting 9afa5b5e0a08: Waiting 1a936d6eb4bb: Waiting f611c8631b7a: Waiting 9e69b0752300: Waiting 6821d50670bb: Waiting f0c9881bb942: Waiting 8d4dbf8eff6f: Verifying Checksum 8d4dbf8eff6f: Download complete 6821d50670bb: Download complete f5d1f35bbc62: Verifying Checksum f5d1f35bbc62: Download complete 6dce3b49cfe6: Verifying Checksum 6dce3b49cfe6: Download complete f611c8631b7a: Verifying Checksum f611c8631b7a: Download complete f5ccc94f7ecd: Verifying Checksum f5ccc94f7ecd: Download complete 9e69b0752300: Verifying Checksum 9e69b0752300: Download complete 5ba6280a28b2: Verifying Checksum 5ba6280a28b2: Download complete 38d1487ce130: Verifying Checksum 38d1487ce130: Download complete 7dc32407334f: Download complete b65c1122fe40: Verifying Checksum b65c1122fe40: Download complete 6dce3b49cfe6: Pull complete a9da9f0bc52e: Verifying Checksum a9da9f0bc52e: Download complete b96994c5dd4e: Verifying Checksum b96994c5dd4e: Download complete 8d4dbf8eff6f: Pull complete ff37e87dc2dd: Verifying Checksum ff37e87dc2dd: Download complete 9afa5b5e0a08: Verifying Checksum 9afa5b5e0a08: Download complete 7e7d695302a2: Verifying Checksum 7e7d695302a2: Download complete 08f8b18f1669: Verifying Checksum 08f8b18f1669: Download complete f0c9881bb942: Verifying Checksum f0c9881bb942: Download complete f5d1f35bbc62: Pull complete 6821d50670bb: Pull complete 1a936d6eb4bb: Verifying Checksum 1a936d6eb4bb: Download complete 1a936d6eb4bb: Pull complete f611c8631b7a: Pull complete 9e69b0752300: Pull complete f5ccc94f7ecd: Pull complete 5ba6280a28b2: Pull complete 7dc32407334f: Pull complete 38d1487ce130: Pull complete b65c1122fe40: Pull complete 9afa5b5e0a08: Pull complete a9da9f0bc52e: Pull complete b96994c5dd4e: Pull complete ff37e87dc2dd: Pull complete 08f8b18f1669: Pull complete 7e7d695302a2: Pull complete f0c9881bb942: Pull complete Digest: sha256:6619d42c5f0bb5b7fe424a0c5417b28c45f90bc1bb500017812fec5913718517 Status: Downloaded newer image for kubetoolsca/krs-docker-extension:0.0.3 docker.io/kubetoolsca/krs-docker-extension:0.0.3 Pulled imageChecked image labels(required) image label "com.docker.extension.screenshots": URL "https://github.com/kubetoolsca/krs-docker-extension/blob/main/images/image1.png?raw=true" not accessible, status:404: https://docs.docker.com/desktop/extensions-sdk/extensions/labels/ (required) image label "com.docker.extension.screenshots": URL "https://github.com/kubetoolsca/krs-docker-extension/blob/main/images/image2.png?raw=true" not accessible, status:404: https://docs.docker.com/desktop/extensions-sdk/extensions/labels/ Checked metadata.jsonChecked image tag is semverChecked image is multiplatformChecked extension is compatible with current SDK versionInstalled extension successfullyRemoved extension successfullyThe extension "kubetoolsca/krs-docker-extension:0.0.3" hasn't passed the checks to be published.

Please fix the issues and check everything is ok locally with the following command:

docker extension validate -a -s -i kubetoolsca/krs-docker-extension

Then you can trigger the validation commenting /validate when you are ready.

See https://docs.docker.com/desktop/extensions-sdk/extensions/validate/ for more information.

karanveersingh5623 commented 1 month ago

@gtardif , please check the screen , all validation of 0.0.3 image is passing

Image

gtardif commented 1 month ago

Hi @karanveersingh5623 , maybe you're not using the latest version of Desktop locally, since we recently added the validation of image URLs to ensure images are accessible. Looking at the details of your image on Docker Hub, I see the value of the screenshot label, containing 3 screenshots. The first one is accessible, but second and third ones give me a 404 (corresponding to the error above)

karanveersingh5623 commented 1 month ago

/validate

github-actions[bot] commented 1 month ago

:white_check_mark: The extension kubetoolsca/krs-docker-extension is valid :tada:.

Now, @docker/extensions will authorise the publication of the extension to the marketplace. Once the extension is published, this issue will be closed.

In the meantime, please tell us about your experience building a Docker Desktop extension here: https://docs.google.com/forms/d/e/1FAIpQLSdruIWGS9Em0p2jVIixQeiVyQJs27EzLA4ks2YzlBZpWUJC2Q/viewform.

publisher-extensions-bot[bot] commented 1 month ago

:tada: Congratulations, your extension has been published to the marketplace.

It may not appear in your Docker Desktop yet. In that case, restart Docker Desktop (don't worry, users will see it as soon as the cache is refreshed, every ~12 hours).

If you haven't already, please tell us about your experience building a Docker Desktop extension here.