docker / extensions-submissions

Submit your Docker Extension here
Apache License 2.0
11 stars 2 forks source link

[Submission]: MindsDB Docker Extension #74

Closed collabnix closed 1 year ago

collabnix commented 1 year ago

Docker Hub repository name

ajeetraina/mindsdb-docker-extension:1.0.0

Terms of services

github-actions[bot] commented 1 year ago

:white_check_mark: @collabnix has accepted the terms of service.

The automatic validation of your extension has started, you will see the result in ~10 minutes :hourglass_flowing_sand:.

github-actions[bot] commented 1 year ago

:white_check_mark: The extension ajeetraina/mindsdb-docker-extension:1.0.0 is valid :tada:.

Now, @docker/extensions will authorise the publication of the extension to the marketplace. Once the extension is published, this issue will be closed.

In the meantime, please tell us about your experience building a Docker Desktop extension here: https://survey.alchemer.com/s3/7184948/Publishers-Feedback-Form.

gtardif commented 1 year ago

@ajeetraina Taking a quick look out of curiosity and installing the extension, it installed correctly but when opening it I only saw a blank screen. Eventually, it turns out containers are really slow to start (like several minutes) ; is there a way to have some spinner or way to inform the user things are not broken?

collabnix commented 1 year ago

Yes. I was thinking of similar kind of implementation few days back. I am not sure how complex it gonna be to implement a spinner but can check with the team internally.

gtardif commented 1 year ago

The image started by the compose app is not multi-arch ; this might be a reason for things being so slow (as it transparently runs on my M1 machine, but emulated with Rosetta). We have something in our backlog to also check images mentioned in the compose file and verify they are multi-arch in the validation process ; for now, could you ensure that all are multi-arch (not sure it will solve the startup time issue, but it can't hurt)

collabnix commented 1 year ago

@gtardif You're right. It might be the reason as MindsDB doesn't official ship Arm-based images. I tried using make push-extension and tried pushing both amd64 and arm-based images but I do understand that it might be slow due to emulated version.

benja-M-1 commented 1 year ago

Hi @collabnix what do you wanna do with the extension? Do you wanna try to improve the loading experience before the extension is published?

collabnix commented 1 year ago

@benja-M-1 We might need to put this on-hold for sometime. I have raised a feature request with MindsDB for shipping Arm-based Docker image to the Docker Hub. Once they push it, I should be able to build it for both architecture.

benja-M-1 commented 1 year ago

Alright, do you mind if we close the issue for now and reopen it once you go an answer? It makes our work easier when we screen for updates on issues.

collabnix commented 1 year ago

Sure. We can go ahead and close this thread.