search

docker / for-mac

Bug reports for Docker Desktop for Mac
https://www.docker.com/products/docker#/mac
2.44k stars 119 forks source link

Enable Kubernetes Feature Gates / Switch Between Kubernetes Versions #2382

Open frankgreco opened 6 years ago

frankgreco commented 6 years ago

Expected behavior

I expect there to be a way to enable feature gates on the Kubernetes API server. I also expected to be able to switch between Kubernetes versions.

Actual behavior

Perhaps this is possible, just not documented, but I don't know if there is a way to enable feature gates on the API server or switch between Kubernetes versions.

Information



  - A reproducible case if this is a bug, Dockerfiles FTW **N/A**
  - Page URL if this is a docs issue or the name of a man page **N/A**

### Steps to reproduce the behavior
**N/A**
guillaumerose commented 6 years ago

Unfortunately not for the moment. We will update to 1.9 in the next release if everything goes well.

frankgreco commented 6 years ago

@guillaumerose is there a somewhere I can track release dates (e.g. expected date the next release will occur). Also, which feature gates do you enabled on the apiserver by default

guillaumerose commented 6 years ago

We follow the same release dates as docker-ce. Every rc goes to edge channel. You can expect 2-3 releases per month.

We use default feature gates of kubeadm. The list is here: https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/app/features/features.go#L49

docker-robott commented 6 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale comment. Stale issues will be closed after an additional 30d of inactivity.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so.

Send feedback to Docker Community Slack channels #docker-for-mac or #docker-for-windows. /lifecycle stale

frankgreco commented 6 years ago

/remove-lifecycle stale

frankgreco commented 6 years ago

@guillaumerose should this issue still be in triage mode? Is this a feature that is planning on being implemented in the future?

guillaumerose commented 6 years ago

For the moment, we are focusing on the upgrade to 1.10. I believe at some point you will be able to customize the kubeadm MasterConfiguration that we use. But not in a near future, sorry :/

/lifecycle frozen

mohnishkodnani commented 5 years ago

any updates on this, i wanted to enable a feature-gate for 1.10

Venryx commented 3 years ago

Any update or workaround for this a couple years later?

It'd be quite useful for enabling feature-gate flags, eg. for enabling Ephemeral Containers for easier pod debugging.

EDIT: Also noticed this issue, which seems related: https://github.com/docker/for-mac/issues/2771

Venryx commented 3 years ago

Several hours later, and I finally found a way to enable Kubernetes feature-gates in Docker Desktop.

See this stack-overflow answer for the painful story of my path toward finding out how.

TL;DR

Steps: 1) Open the [...]/kubeadm/manifests folder, in the Docker filesystem. (on Windows, navigate Windows Explorer to: \\wsl$\docker-desktop-data\version-pack-data\community\kubeadm\manifests) 2) Open the kube-controller-manager.yaml, kube-apiserver.yaml, and kube-scheduler.yaml files, adding the line below:

spec:
  containers:
  - command:
    [...]
    - --feature-gates=EphemeralContainers=true     <-- add this line (or whatever feature-gate flags you need)

3) Restart Docker Desktop.