docker / for-mac

Bug reports for Docker Desktop for Mac
https://www.docker.com/products/docker#/mac
2.43k stars 117 forks source link

Docker's Icon is the only round icon in my Dock #5536

Closed simoncpu closed 2 years ago

simoncpu commented 3 years ago

Expected behavior

The Human Interface Guidelines state that the app icon should be square with no round corners.

Actual behavior

Docker's icon is round.

Information

djs55 commented 3 years ago

@simoncpu thanks for your report! I've created a ticket and added it to our backlog.

niccolomineo commented 3 years ago

It should be pointed out that the icon is not a square, but, rather, a squircle. Apple's been quite clear about this.

Anyhow, I am looking forward to the change.

niccolomineo commented 3 years ago

Hi, any updates on this?

Thank you.

niccolomineo commented 3 years ago

Since 3.4.0 didn't bring the new icon, I made it myself. Feel free to use it.

https://www.figma.com/file/uhytxqvq1PQgOfpOQGshn2/Docker-macOS-Big-Sur-Icon

Schermata 2021-06-10 alle 17 49 30
aluneed commented 3 years ago

Since 3.4.0 didn't bring the new icon, I made it myself. Feel free to use it.

https://www.figma.com/file/uhytxqvq1PQgOfpOQGshn2/Docker-macOS-Big-Sur-Icon

Schermata 2021-06-10 alle 17 49 30

looks much better than the official one.

mrleblanc101 commented 3 years ago

When can we expect Docker to update the app icon to respect the macOS guideline ? The change has been announced more than a year ago and this feels like a change that would only take a few minutes if someone actually cared to execute this task.

niccolomineo commented 3 years ago

I am attaching the icon set in the various sizes.

Docker macOS Big Sur Icon.zip

desmortum commented 3 years ago

More and more apps getting new icons. Very excited to see new icon aligned with new guidelines.

niccolomineo commented 3 years ago

We're still with the round icon though.

desmortum commented 2 years ago

Docker has old icon for year now after Big Sur release. It introduces kind of inconsistency with other icons. It will be great to see new icon aligned with guidelines.

desmortum commented 2 years ago

@djs55, any news?

gk-brown commented 2 years ago

I logged in just to find/upvote or create this issue, if it did not already exist. I installed Docker Desktop for macOS yesterday and love it so far. But I would like to see the icon updated for consistency with current Apple guidelines.

prksu commented 2 years ago

still has a round icon in 4.5.0 (74594) 😞

desmortum commented 2 years ago

This is clearly ignored by some developers. In 2020 Apple released a new guidelines for macOS app icons to look like IOS ones: a rectangles with rounded corners. Now that most apps got updated, the ones that didn't produce inconsistency in dock and Launchpad. It's been more than a year since guidelines were released.

henriquemattos commented 2 years ago

The changelog for 4.8.0 says it was released, and points out this issue here, but it's still rounded on my macOS. Considering that Firefox Developer Edition also disrespect the guideline, I don't see it as a big drama. Although always in favor of respecting branding and styles.

Screenshot 2022-05-06 at 10 46 07

,

niccolomineo commented 2 years ago

The changelog for 4.8.0 says it was released, and points out this issue here, but it's still rounded on my macOS. Considering that Firefox Developer Edition also disrespect the guideline, I don't see it as a big drama. Although always in favor of respecting branding and styles.

Screenshot 2022-05-06 at 10 46 07

,

Weird, it works here. Did you try to simply restart Docker again, after the update forced restart? That's what was needed, on my machine.

A feedback I'd like to give is that the blue doesn't match the one of the UI buttons, but, hey, we got the icon at least. 🎉

desmortum commented 2 years ago

Icon updated for me

desmortum commented 2 years ago
Screen Shot 2022-05-06 at 12 06 23
henriquemattos commented 2 years ago

I'm sorry for the misleading comment. I tried by restarting Docker and also by quitting and starting it again. And it didn't change.

I noticed I'm using Monterey (macOS 12) and the icon is "only" for Big Sur (macOS 11). I tried to find documentation/guidelines from Apple, but it's only mentioned macOS 11.

Given the native Apple's app icons (like Calendar, Mail, Messages...), I would say the guideline has been maintained. What do you think?

desmortum commented 2 years ago

I'm sorry for the misleading comment. I tried by restarting Docker and also by quitting and starting it again. And it didn't change.

I noticed I'm using Monterey (macOS 12) and the icon is "only" for Big Sur (macOS 11). I tried to find documentation/guidelines from Apple, but it's only mentioned macOS 11.

Given the native Apple's app icons (like Calendar, Mail, Messages...), I would say the guideline has been maintained. What do you think?

That would've been nonsense. Of course guidelines are FROM Big Sur on including all following OS versions. If Docker changes icon not for version 11 and above but for 11 exactly, that's clearly a bug.

desmortum commented 2 years ago

@djs55

niccolomineo commented 2 years ago

I'm sorry for the misleading comment. I tried by restarting Docker and also by quitting and starting it again. And it didn't change.

I noticed I'm using Monterey (macOS 12) and the icon is "only" for Big Sur (macOS 11). I tried to find documentation/guidelines from Apple, but it's only mentioned macOS 11.

Given the native Apple's app icons (like Calendar, Mail, Messages...), I would say the guideline has been maintained. What do you think?

That would make no sense, yeah. Also, I have Monterey myself and the icon is there.

desmortum commented 2 years ago

@henriquemattos, I just finally installed Monterey and icon is correct. So I guess problem is on your machine. Try removing Docker.app from /Applications. Then drag new one from freshly downloaded *.dmg. Should not affect data or settings.

desmortum commented 2 years ago
Screen Shot 2022-05-10 at 13 54 25
lorenrh commented 2 years ago

I'm closing this issue, as a fix for this has been released on Docker Desktop 4.8.1!

breiter commented 2 years ago

While Docker.app has an icon, the embedded Docker Desktop.app does not. And so whenever I open Preferences or About or Check for updates... from the menu bar icon -- anything that launches Docker Desktop.ap -- I get a broken icon in the dock. (This was also the case in 4.6.)

Screen Shot 2022-05-12 at 08 35 50

Screen Shot 2022-05-12 at 08 32 37

desmortum commented 2 years ago

@breiter, hm. For me it's okay.

Screen Shot 2022-05-12 at 09 32 49
thaJeztah commented 2 years ago

@breiter see https://github.com/docker/for-mac/issues/6249

docker-robott commented 2 years ago

Closed issues are locked after 30 days of inactivity. This helps our team focus on active issues.

If you have found a problem that seems similar to this, please open a new issue.

Send feedback to Docker Community Slack channels #docker-for-mac or #docker-for-windows. /lifecycle locked