docker / for-mac

Bug reports for Docker Desktop for Mac
https://www.docker.com/products/docker#/mac
2.43k stars 118 forks source link

Expanding folder in Files explorer not possible after uploading large file #7229

Open hanssens opened 6 months ago

hanssens commented 6 months ago

Description

On Docker Desktop for Mac, version 4.28.0 (139021), certain modified folders underneath the Files tab of a running container instance glitches.

See vid below, where a change is made to /opt which works fine. But a large file uploaded to /tmp makes it impossible to expand the folder and access files underneath in the treeview:

https://github.com/docker/for-mac/assets/493382/3fcaac42-00c3-44ee-bda7-f3ceab45ba20

You have to wait a long time, swap between tabs (Exec, Stats, Bind mounts, Inspect etc.) and after minutes it might expand.

Reproduce

In Docker Desktop:

1.) On a random, running Docker instance, navigate to Files 2.) Upload a large file (+4GB) into a subfolder - and wait for it to complete 3.) The file explorer shows "modified" 3.) Restart the container instance (<-- step might not be neccessary) 4.) Try to expand the folder where the uploaded file

Expected behavior

Modified folder containg the uploaded, large file would open/expand immediately. Just like other folders.

docker version

Client:
 Cloud integration: v1.0.35+desktop.11
 Version:           25.0.3
 API version:       1.44
 Go version:        go1.21.6
 Git commit:        4debf41
 Built:             Tue Feb  6 21:13:26 2024
 OS/Arch:           darwin/arm64
 Context:           desktop-linux

Server: Docker Desktop 4.28.0 (139021)
 Engine:
  Version:          25.0.3
  API version:      1.44 (minimum version 1.24)
  Go version:       go1.21.6
  Git commit:       f417435
  Built:            Tue Feb  6 21:14:22 2024
  OS/Arch:          linux/arm64
  Experimental:     false
 containerd:
  Version:          1.6.28
  GitCommit:        ae07eda36dd25f8a1b98dfbf587313b99c0190bb
 runc:
  Version:          1.1.12
  GitCommit:        v1.1.12-0-g51d5e94
 docker-init:
  Version:          0.19.0
  GitCommit:        de40ad0

docker info

Client:
 Version:    25.0.3
 Context:    desktop-linux
 Debug Mode: false
 Plugins:
  buildx: Docker Buildx (Docker Inc.)
    Version:  v0.12.1-desktop.4
    Path:     /Users/hanssens/.docker/cli-plugins/docker-buildx
  compose: Docker Compose (Docker Inc.)
    Version:  v2.24.6-desktop.1
    Path:     /Users/hanssens/.docker/cli-plugins/docker-compose
  debug: Get a shell into any image or container. (Docker Inc.)
    Version:  0.0.24
    Path:     /Users/hanssens/.docker/cli-plugins/docker-debug
  dev: Docker Dev Environments (Docker Inc.)
    Version:  v0.1.0
    Path:     /Users/hanssens/.docker/cli-plugins/docker-dev
  extension: Manages Docker extensions (Docker Inc.)
    Version:  v0.2.22
    Path:     /Users/hanssens/.docker/cli-plugins/docker-extension
  feedback: Provide feedback, right in your terminal! (Docker Inc.)
    Version:  v1.0.4
    Path:     /Users/hanssens/.docker/cli-plugins/docker-feedback
  init: Creates Docker-related starter files for your project (Docker Inc.)
    Version:  v1.0.1
    Path:     /Users/hanssens/.docker/cli-plugins/docker-init
  sbom: View the packaged-based Software Bill Of Materials (SBOM) for an image (Anchore Inc.)
    Version:  0.6.0
    Path:     /Users/hanssens/.docker/cli-plugins/docker-sbom
  scout: Docker Scout (Docker Inc.)
    Version:  v1.5.0
    Path:     /Users/hanssens/.docker/cli-plugins/docker-scout

Server:
 Containers: 2
  Running: 1
  Paused: 0
  Stopped: 1
 Images: 2
 Server Version: 25.0.3
 Storage Driver: overlay2
  Backing Filesystem: extfs
  Supports d_type: true
  Using metacopy: false
  Native Overlay Diff: true
  userxattr: false
 Logging Driver: json-file
 Cgroup Driver: cgroupfs
 Cgroup Version: 2
 Plugins:
  Volume: local
  Network: bridge host ipvlan macvlan null overlay
  Log: awslogs fluentd gcplogs gelf journald json-file local splunk syslog
 Swarm: inactive
 Runtimes: io.containerd.runc.v2 runc
 Default Runtime: runc
 Init Binary: docker-init
 containerd version: ae07eda36dd25f8a1b98dfbf587313b99c0190bb
 runc version: v1.1.12-0-g51d5e94
 init version: de40ad0
 Security Options:
  seccomp
   Profile: unconfined
  cgroupns
 Kernel Version: 6.6.16-linuxkit
 Operating System: Docker Desktop
 OSType: linux
 Architecture: aarch64
 CPUs: 8
 Total Memory: 11.67GiB
 Name: docker-desktop
 ID: 2a1d9ec5-097d-454b-b4dc-e35fd28b40b2
 Docker Root Dir: /var/lib/docker
 Debug Mode: false
 HTTP Proxy: http.docker.internal:3128
 HTTPS Proxy: http.docker.internal:3128
 No Proxy: hubproxy.docker.internal
 Experimental: false
 Insecure Registries:
  hubproxy.docker.internal:5555
  127.0.0.0/8
 Live Restore Enabled: false

Diagnostics ID

B5A17B5F-59E6-4AFE-9CA1-299B2F463911/20240328122411

Additional Info

Things tried that do not fix the issue:

ahmad-badpey commented 6 months ago

I have the same problem on Mac while using the latest version

sn-dustin commented 5 months ago

I am also experiencing this even without uploading very large files.

Sverber commented 5 months ago

It does not solve the actual problem, but might help others that experience the same issue. First time I noticed that it'd resolved the issue was a couple weeks ago, but just now for a second time. At first I thought it was sheer luck, but as it occurred a second time - it might actually have helped.

What helped for me: In all cases the problem occurred, I had my RavenDB instance opened in my browser. Once I closed this instance in my browser, restarted and/or navigated again to my docker instance > files tab, I was able to open the folder that previously kept closing.

ipenburg commented 5 months ago

My related problem on WIndows: Modified folders in the Files tab seem to open and immediately close again when clicked on using a mouse. Navigating to a folder using arrow keys and opening it with space using the keyboard opens the folder and the hierarchy is navigable this way but using the mouse to interact with the revealed files closes the modified folder again although the contextual menu stays open and this way a file can be saved, deleted, etc. Rolled back to 4.27.2 to avoid this issue.

flavigneseedbox commented 5 months ago

Happens to me too without large files. Usually it's /etc that does this.

ZeckWork commented 4 months ago

I have de same problem

FabianSilva commented 4 months ago

same on windows 11, docker 4.29.0, without uploading anything, only viewing a modified folder (app save logs on it), clicked on opt/app/... tree, it shows and hides content

ZacharyMohler commented 3 months ago

windows 11, docker 4.31.1 Issue still happening (It's infuriating by the way)

Taurophylax commented 3 months ago

Potential workaround until this gets fixed is to stop the container (don't restart, stop it), then start it again- make sure everything is booted up before trying again.

umut-saribiyik88 commented 2 months ago

I have the same issue, and a possible workaround is to focus on the folder that's not expanding and then press the spacebar on your keyboard to open it.

jotremb commented 2 months ago

To me, it seems to happen to any folder (and parent folders) that have been modified via the "Files" browser tab, whether it's "import" or "edit file". After the folder/file has been modified, going to another tab (ie: Exec, Logs...) then coming back into "Files" will make the whole modified tree unworkable. Sometimes quitting the interface and re-opening it will temporarily fix it...

landism commented 1 month ago

Docker Desktop 4.34.0 will contain a fix for expanding folders in the file explorer.

The fix is not specific to large files, though. With the fix in place, I was unable to reproduce the bug with large files, so I'm wondering the "large file" part of this report is a red herring. If anyone has seen this bug occur only with large files while it consistently works just fine on non-large files, I'm interested in hearing about it. Thanks!

fabramattos commented 1 month ago

Same problem with Docker Desktop 4.33.1 on windows 11, but on folders tagged as VOLUME. Any other folder works fine.