search

docker / for-mac

Bug reports for Docker Desktop for Mac
https://www.docker.com/products/docker#/mac
2.43k stars 117 forks source link

Missing `DELETE` inotify event with VirtioFS #7246

Open oprypkhantc opened 7 months ago

oprypkhantc commented 7 months ago

Description

Hey.

While other events (CREATE, ATTRIB, MODIFY, possibly others) are correctly propagated from the host, the DELETE event is not triggered for files and nested directories at all.

Reproduce

  1. Switch to the new Virtualization Framework and enable VirtioFS
  2. Run docker run --rm -it --volume "$(pwd)":/app -w /app alpine:3.18 sh
  3. Run apk update && apk add inotify-tools && inotifywait -m -r -e modify -e attrib -e moved_to -e moved_from -e move -e move_self -e create -e delete -e delete_self -e unmount .
  4. In a new terminal, run mkdir test && touch test/file - you'll see the events from inotifywait
  5. Run rm test/file - no events:
Setting up watches.  Beware: since -r was given, this may take a while!
Watches established.
./test/ CREATE file
./test/ ATTRIB file
./test/ MODIFY file

Expected behavior

Removing a file should have emitted a DELETE inotify event:

Setting up watches.  Beware: since -r was given, this may take a while!
Watches established.
./test/ CREATE file
./test/ ATTRIB file
./test/ MODIFY file
./test/ DELETE file

docker version

Client:
 Cloud integration: v1.0.35+desktop.13
 Version:           26.0.0
 API version:       1.45
 Go version:        go1.21.8
 Git commit:        2ae903e
 Built:             Wed Mar 20 15:14:46 2024
 OS/Arch:           darwin/arm64
 Context:           desktop-linux

Server: Docker Desktop 4.29.0 (145265)
 Engine:
  Version:          26.0.0
  API version:      1.45 (minimum version 1.24)
  Go version:       go1.21.8
  Git commit:       8b79278
  Built:            Wed Mar 20 15:18:02 2024
  OS/Arch:          linux/arm64
  Experimental:     false
 containerd:
  Version:          1.6.28
  GitCommit:        ae07eda36dd25f8a1b98dfbf587313b99c0190bb
 runc:
  Version:          1.1.12
  GitCommit:        v1.1.12-0-g51d5e94
 docker-init:
  Version:          0.19.0
  GitCommit:        de40ad0

docker info

Client:
 Version:    26.0.0
 Context:    desktop-linux
 Debug Mode: false
 Plugins:
  buildx: Docker Buildx (Docker Inc.)
    Version:  v0.13.1-desktop.1
    Path:     /Users/alex/.docker/cli-plugins/docker-buildx
  compose: Docker Compose (Docker Inc.)
    Version:  v2.26.1-desktop.1
    Path:     /Users/alex/.docker/cli-plugins/docker-compose
  debug: Get a shell into any image or container. (Docker Inc.)
    Version:  0.0.27
    Path:     /Users/alex/.docker/cli-plugins/docker-debug
  dev: Docker Dev Environments (Docker Inc.)
    Version:  v0.1.2
    Path:     /Users/alex/.docker/cli-plugins/docker-dev
  extension: Manages Docker extensions (Docker Inc.)
    Version:  v0.2.23
    Path:     /Users/alex/.docker/cli-plugins/docker-extension
  feedback: Provide feedback, right in your terminal! (Docker Inc.)
    Version:  v1.0.4
    Path:     /Users/alex/.docker/cli-plugins/docker-feedback
  init: Creates Docker-related starter files for your project (Docker Inc.)
    Version:  v1.1.0
    Path:     /Users/alex/.docker/cli-plugins/docker-init
  sbom: View the packaged-based Software Bill Of Materials (SBOM) for an image (Anchore Inc.)
    Version:  0.6.0
    Path:     /Users/alex/.docker/cli-plugins/docker-sbom
  scout: Docker Scout (Docker Inc.)
    Version:  v1.6.3
    Path:     /Users/alex/.docker/cli-plugins/docker-scout
WARNING: Plugin "/Users/alex/.docker/cli-plugins/docker-scan" is not valid: failed to fetch metadata: fork/exec /Users/alex/.docker/cli-plugins/docker-scan: no such file or directory

Server:
 Containers: 21
  Running: 17
  Paused: 0
  Stopped: 4
 Images: 96
 Server Version: 26.0.0
 Storage Driver: overlay2
  Backing Filesystem: extfs
  Supports d_type: true
  Using metacopy: false
  Native Overlay Diff: true
  userxattr: false
 Logging Driver: json-file
 Cgroup Driver: cgroupfs
 Cgroup Version: 2
 Plugins:
  Volume: local
  Network: bridge host ipvlan macvlan null overlay
  Log: awslogs fluentd gcplogs gelf journald json-file local splunk syslog
 Swarm: inactive
 Runtimes: io.containerd.runc.v2 runc
 Default Runtime: runc
 Init Binary: docker-init
 containerd version: ae07eda36dd25f8a1b98dfbf587313b99c0190bb
 runc version: v1.1.12-0-g51d5e94
 init version: de40ad0
 Security Options:
  seccomp
   Profile: unconfined
  cgroupns
 Kernel Version: 6.6.22-linuxkit
 Operating System: Docker Desktop
 OSType: linux
 Architecture: aarch64
 CPUs: 10
 Total Memory: 7.755GiB
 Name: docker-desktop
 ID: fd87b25c-7323-4697-80dd-448787d2a577
 Docker Root Dir: /var/lib/docker
 Debug Mode: false
 HTTP Proxy: http.docker.internal:3128
 HTTPS Proxy: http.docker.internal:3128
 No Proxy: hubproxy.docker.internal
 Labels:
  com.docker.desktop.address=unix:///Users/alex/Library/Containers/com.docker.docker/Data/docker-cli.sock
 Experimental: false
 Insecure Registries:
  hubproxy.docker.internal:5555
  127.0.0.0/8
 Live Restore Enabled: false

WARNING: daemon is not using the default seccomp profile

Diagnostics ID

CD563FB5-0B9A-4E81-8B60-1A2209EF53E8/20240410132019

Additional Info

No response

colradec commented 7 months ago

This problem seems to be nearly identical to this issue I have. https://github.com/docker/for-mac/issues/7210 with the difference of the NFS mount. There have been modifications regarding mounts in the moby/moby version used in 4.22.0 however, it should only affect rootless mounts that should not affect any other mounts.

Seems, that I can save time and skip testing against 4.29.0.