docker / for-mac

Bug reports for Docker Desktop for Mac
https://www.docker.com/products/docker#/mac
2.43k stars 118 forks source link

Syncronized file share broken since v4.34.2 #7421

Open NiklasBr opened 5 days ago

NiklasBr commented 5 days ago

Description

Something in the update from v4.32 to v4.34.2 completely broke all file shares on Mac OS.

Reproduce

  1. Enable file share
  2. Change a file
  3. Try to access the updated file in the share

Result: it never changes in the share even though the "status" says it is up-to-date.

Expected behavior

The file should be updated in the share.

docker version

Client:
 Version:           27.2.0
 API version:       1.47
 Go version:        go1.21.13
 Git commit:        3ab4256
 Built:             Tue Aug 27 14:14:45 2024
 OS/Arch:           darwin/arm64
 Context:           desktop-linux

Server: Docker Desktop 4.34.2 (167172)
 Engine:
  Version:          27.2.0
  API version:      1.47 (minimum version 1.24)
  Go version:       go1.21.13
  Git commit:       3ab5c7d
  Built:            Tue Aug 27 14:15:41 2024
  OS/Arch:          linux/arm64
  Experimental:     false
 containerd:
  Version:          1.7.20
  GitCommit:        8fc6bcff51318944179630522a095cc9dbf9f353
 runc:
  Version:          1.1.13
  GitCommit:        v1.1.13-0-g58aa920
 docker-init:
  Version:          0.19.0
  GitCommit:        de40ad0

docker info

Client:
 Version:    27.2.0
 Context:    desktop-linux
 Debug Mode: false
 Plugins:
  buildx: Docker Buildx (Docker Inc.)
    Version:  v0.16.2-desktop.1
    Path:     /Users/nikbr/.docker/cli-plugins/docker-buildx
  compose: Docker Compose (Docker Inc.)
    Version:  v2.29.2-desktop.2
    Path:     /Users/nikbr/.docker/cli-plugins/docker-compose
  debug: Get a shell into any image or container (Docker Inc.)
    Version:  0.0.34
    Path:     /Users/nikbr/.docker/cli-plugins/docker-debug
  desktop: Docker Desktop commands (Alpha) (Docker Inc.)
    Version:  v0.0.15
    Path:     /Users/nikbr/.docker/cli-plugins/docker-desktop
  dev: Docker Dev Environments (Docker Inc.)
    Version:  v0.1.2
    Path:     /Users/nikbr/.docker/cli-plugins/docker-dev
  extension: Manages Docker extensions (Docker Inc.)
    Version:  v0.2.25
    Path:     /Users/nikbr/.docker/cli-plugins/docker-extension
  feedback: Provide feedback, right in your terminal! (Docker Inc.)
    Version:  v1.0.5
    Path:     /Users/nikbr/.docker/cli-plugins/docker-feedback
  init: Creates Docker-related starter files for your project (Docker Inc.)
    Version:  v1.3.0
    Path:     /Users/nikbr/.docker/cli-plugins/docker-init
  sbom: View the packaged-based Software Bill Of Materials (SBOM) for an image (Anchore Inc.)
    Version:  0.6.0
    Path:     /Users/nikbr/.docker/cli-plugins/docker-sbom
  scout: Docker Scout (Docker Inc.)
    Version:  v1.13.0
    Path:     /Users/nikbr/.docker/cli-plugins/docker-scout
WARNING: Plugin "/Users/nikbr/.docker/cli-plugins/docker-scan" is not valid: failed to fetch metadata: fork/exec /Users/nikbr/.docker/cli-plugins/docker-scan: no such file or directory

Server:
 Containers: 28
  Running: 12
  Paused: 0
  Stopped: 16
 Images: 72
 Server Version: 27.2.0
 Storage Driver: overlayfs
  driver-type: io.containerd.snapshotter.v1
 Logging Driver: json-file
 Cgroup Driver: cgroupfs
 Cgroup Version: 2
 Plugins:
  Volume: local
  Network: bridge host ipvlan macvlan null overlay
  Log: awslogs fluentd gcplogs gelf journald json-file local splunk syslog
 Swarm: inactive
 Runtimes: io.containerd.runc.v2 runc
 Default Runtime: runc
 Init Binary: docker-init
 containerd version: 8fc6bcff51318944179630522a095cc9dbf9f353
 runc version: v1.1.13-0-g58aa920
 init version: de40ad0
 Security Options:
  seccomp
   Profile: unconfined
  cgroupns
 Kernel Version: 6.10.4-linuxkit
 Operating System: Docker Desktop
 OSType: linux
 Architecture: aarch64
 CPUs: 9
 Total Memory: 23.44GiB
 Name: docker-desktop
 ID: 4bacd5ea-52d7-4544-a700-b29136ca8a38
 Docker Root Dir: /var/lib/docker
 Debug Mode: false
 HTTP Proxy: http.docker.internal:3128
 HTTPS Proxy: http.docker.internal:3128
 No Proxy: hubproxy.docker.internal
 Labels:
  com.docker.desktop.address=unix:///Users/nikbr/Library/Containers/com.docker.docker/Data/docker-cli.sock
 Experimental: false
 Insecure Registries:
  hubproxy.docker.internal:5555
  127.0.0.0/8
 Live Restore Enabled: false

WARNING: daemon is not using the default seccomp profile

Diagnostics ID

39263439-8ED3-425A-A6C1-A4B1DD929F05/20240916085406

Additional Info

No response

xenoscopic commented 5 days ago

Hey @NiklasBr, I'm unable to reproduce this issue on my machine, but maybe I can get the information needed from your diagnostics bundle (EDIT: I didn't realize you had already uploaded one, apologies).

Does the Synchronize File Shares pane indicate any sort of errors, problems, or conflicts for the file sync?

Finally, were these synchronized file shares that existed prior to 4.34.2? Or does the problem occur for both existing synchronized file shares and new ones?

xenoscopic commented 5 days ago

Looking at the diagnostics, I don't see any errors that would prevent the changes from propagating. If you exit and restart Docker Desktop, do the changes propagate after that?

NiklasBr commented 5 days ago

Does the Synchronize File Shares pane indicate any sort of errors, problems, or conflicts for the file sync?

It indicates no such things, it's all "fine" according to the settings section.

Finally, were these synchronized file shares that existed prior to 4.34.2?

These existed for a while prior to 4.34.2, maybe since 4.29 or thereabout.

If you exit and restart Docker Desktop, do the changes propagate after that?

Yes, they propagate once then it stops. No further changes propagate into the running container. If I then restart Docker the changes propagate, but then no further changes propagate until I restart it again.

NiklasBr commented 2 days ago

Any ideas @xenoscopic? I have downgraded to v4.32.0 and it restores working file shares without needing to do anything. But I can't run outdated insecure software for too long.

xenoscopic commented 2 days ago

@NiklasBr Unfortunately not yet. I was testing this morning with DD 4.29, creating shares and then upgrading to 4.34.2, but all changes continue to propagate, including after the first. I've also looked through more of the logs in the diagnostic bundle you sent but haven't seen anything yet. I will get some time allocated during our next sprint (starting today) to delve further and hopefully get this sorted out. Is there any chance we could do a short (20-30 minute) screen share session early next week to walk through debugging on your machine? This may be related to docker/for-mac#7281, so perhaps we can follow up on that one as well.

NiklasBr commented 2 days ago

Sure, send me an invite for Monday after 13 o'clock or Wednesday after 10 (CET), you have my email already.