settings are not migrated when downgrade from v4.35.1 do change from UI and then re-upgrade to v4.35.1

Riete commented 2 weeks ago

Description

Docker Desktop 4.35.1 (173168)

After upgrade from 4.34.3 to 4.35.1, I enable VMM, But when restart the docker, the status is always stuck at starting. After same research, I found it's caused by low memory limit setting, here I set memory limit to 1GB, so I revert to 4.34.3 and set memory limit to 4GB, then upgrade to v4.35.1 again，but it still stuck at starting, seems the setting change has no effect.

Finally, I find the root casue is Docker Desktop setting config file changed from settings.json to settings-store.json where locate at ~/Library/Group\ Containers/group.com.docker since v4.35.x, I need to change the memory setting in settings-store.json, then docekr start successful.

In my case, downgrade -> change settings from UI -> upgrade can't solve the issue, then only way is to find the right config file and modify it.

Reproduce

Expected behavior

No response

docker version

N/A

docker info

N/A

Diagnostics ID

N/A

Additional Info

No response

thaJeztah commented 2 weeks ago

cc @chelnak @djs55

djs55 commented 2 weeks ago

Thanks for the report. We're investigating applying the memory change on upgrade.

In my case, downgrade -> change settings from UI -> upgrade can't solve the issue, then only way is to find the right config file and modify it.

I'm glad you managed to edit your config file and fix the issue locally. Sorry for the inconvenience.

For the benefit of anyone else reading this, to fix the DockerVMM minimum memory issue on Docker 4.35.1:

stop Docker 4.35.1
edit ~/Library/Group\ Containers/group.com.docker/settings-store.json to change MemoryMiB:
```
"MemoryMiB": 4096,
```
restart DD 4.35.1

docker / for-mac