docker / for-win

Bug reports for Docker Desktop for Windows
https://www.docker.com/products/docker#/windows
1.86k stars 290 forks source link

Docker for Windows should not be utilizing TrustedInstaller #1981

Open StingyJack opened 6 years ago

StingyJack commented 6 years ago

After uninstalling docker for windows, i have a c:\programdata\docker folder that has 20GB of files I cannot delete. This is because they are owned by TrustedInstaller.

TrustedInstaller is supposed to be protecting OS critical files. Docker for windows is a service, and the files in question are important only to that service. Removing them would not cause host OS instability, so its unnecessary (and frustrating) to mark them as if it would.

I have been able to rid my system of these files in the meantime, and that is not the issue being reported here. There are many methods for removing the files already posted, but the underlying cause of the issue does not seem to be getting addressed.

stephen-turner commented 6 years ago

@StingyJack Thanks for the report. Which specific files are owned by TrustedInstaller? Or is it the whole folder? I'm not finding them on my system, nor by Googling.

terraslate commented 6 years ago

All of them on every system in the world i'd hazard a guess. I'm currently trying to figure out how to remove them myself, i've written a service to run as system but to no avail. Junction won't remove them, now i will need to research how to run as trustedinstaller or something. Clearly these are all links to the original files and therefore should not take up any extra space (much) but i don't want them there.

thaJeztah commented 6 years ago

I don't think it's related to the installer, but because of how the Windows storage driver creates container filesystems. This may help though; https://github.com/jhowardmsft/docker-ci-zap

StingyJack commented 6 years ago

@stephen-turner - The spacehogs are usually in C:\ProgramData\Docker\windowsfilter

Trusted Installer is a special account (more special than system/localsystem) that is supposed to be protecting operating system files from accidental deletion. These files are copies of system files and are are created by Docker for Windows. We shouldn't have to resort to a special "Zap" program to remove files that an uninstall should be taking care of.

This program would not work correctly for one reason after another when it was installed (not a corrupted installation). Now it wont even leave my system completely when uninstalled.

docker-robott commented 6 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale comment. Stale issues will be closed after an additional 30d of inactivity.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so.

Send feedback to Docker Community Slack channels #docker-for-mac or #docker-for-windows. /lifecycle stale

StingyJack commented 6 years ago

/lifecycle frozen

I dont like.that bot