search

docker / for-win

Bug reports for Docker Desktop for Windows
https://www.docker.com/products/docker#/windows
1.85k stars 285 forks source link

docker always restores credStore desktop #9843

Closed stefanloerwald closed 1 week ago

stefanloerwald commented 3 years ago

I don't want to use the default credStore "desktop" on my development machine. The issue https://github.com/docker/docker-credential-helpers/issues/95 guides me to set the credStore/credsStore value to "" instead of "desktop", but it doesn't seem to have any effect while docker is running. Restarting docker will reset this value to "desktop".

Please fix this.

raeldc commented 3 months ago

This problem still exists

MihaelaStoica commented 2 months ago

We had made some fixes in this area, namely to the issue that a valid value in credsStore in ~/.docker/config.json was reverted back to desktop after a Docker Desktop restart. These fixes have been included in Docker Desktop 4.19 (release note), with an additional fix for WSL in Docker Desktop 4.27 (release note).

However the issue reported here - that if credsStore is set to "" or removed completely, restarting Docker Desktop will reset this value to "desktop" - remains. We are looking into it.

rsanchezc-pg commented 1 month ago

On Mac with docker desktop 4.33 and docker cli 27.1.1, I'm facing the issue that every time docker desktop starts it resets 'credStore' to 'credsStore', which is breaking the login to my Azure Container Registry.

skwid138 commented 1 month ago

I have been experiencing a very similar issue to @rsanchezc-pg

~/.docker/config.json has a key credsStore on startup If I attempt to start containers it will throw errors containing error getting credentials - err: exec: "docker-credential-desktop": executable file not found in $PATH The errors are resolved when I change credsStore to credStore That change is reverted when docker restarts

Docker version: 27.1.1, build 63125853e3 Docker Desktop: 4.32.0 (157355) Mac OS: 12.6

lorenrh commented 1 week ago

4.34.0 has been released with a fix for this issue, more information o the release notes.

I'll be closing this issue, but if the problem persists please open a fresh issue!