search

docker / go-imageinspect

Apache License 2.0
15 stars 2 forks source link

Typed `Result.Platforms` #22

Open crazy-max opened 1 year ago

crazy-max commented 1 year ago

Instead of a slice of strings in https://github.com/docker/go-imageinspect/blob/0c562e4bbd718916ca2b13e81af3b410d6e1bf52/types.go#L30

It would be better to have typed platforms []ocispecs.Platform https://github.com/opencontainers/image-spec/blob/2fb996805b3734779bf9a3a84dc9a9691ad7efdd/specs-go/v1/descriptor.go#L52-L72 so we could have OSVersion, OSFeatures.

String representation could then be:

   - linux/ppc64le
   - linux/amd64
   - linux/386
   - linux/s390x
   - linux/riscv64
   - linux/arm64
   - linux/arm/v7
   - linux/arm/v6
   - windows/amd64:10.0.17763.2300
   - windows/amd64:10.0.14393.4770