search

docker / go-metrics

Package for metrics collection in Docker projects
Apache License 2.0
87 stars 32 forks source link

No longer builds against Prom master #12

Closed justincormack closed 6 years ago

justincormack commented 7 years ago

Getting

../../docker/go-metrics/timer.go:39: cannot use lt.m.WithLabelValues(labels...) (type prometheus.Observer) as type prometheus.Histogram in field value:
    prometheus.Observer does not implement prometheus.Histogram (missing Collect method)
roadrunner commented 7 years ago

@justincormack, I had the same compile error, it fixed after cleanup vendored packages.

stevvooe commented 6 years ago

Note this was caused by https://github.com/prometheus/client_golang/pull/285.

The current fix in place doesn't preserve the abstraction of the go-metrics package, so I'm re-opening this.