search

docker / go-metrics

Package for metrics collection in Docker projects
Apache License 2.0
87 stars 32 forks source link

Support Go Modules #22

Closed SamWhited closed 5 years ago

SamWhited commented 5 years ago

Pin the Prometheus version and support Go Modules. Because this package is not versioned, nothing needs to be done other than adding a go.mod file. If we want to start versioning this package in the future, we can start adding semver compatible tags to give us something to pin to in other projects that depend on this one.

crosbymichael commented 5 years ago

LGTM

SamWhited commented 5 years ago

@crosbymichael thanks! Since this repo isn't updated often (and not likely to be updated all that often), is there any chance you could tag a v0.0.1 or similar just to clean up other projects go.mod files that depend on this?

crosbymichael commented 5 years ago

sure!

crosbymichael commented 5 years ago

@SamWhited done https://github.com/docker/go-metrics/releases/tag/v0.0.1