Remove deprecated graphdriver-plugins, assorted cleanups, and update to go1.21 - Githubissues

docker / go-plugins-helpers

Go helper packages to extend the Docker Engine

https://docs.docker.com/engine/extend/plugins/

Apache License 2.0

333 stars 133 forks source link

Remove deprecated graphdriver-plugins, assorted cleanups, and update to go1.21 #138

Closed thaJeztah closed 4 months ago

thaJeztah commented 4 months ago

relates to https://github.com/moby/moby/pull/48050
relates to https://github.com/docker/cli/pull/5172
relates to https://github.com/moby/moby/pull/48072

gofmt, update to go1.21 and remove legacy build-tags

remove deprecated graphdriver-plugins (experimental)

The experimental graphdriver plugins were deprecated in docker 27.0, and removed in docker 28.0. https://docs.docker.com/engine/deprecated/#graphdriver-plugins-experimental

This removes the helpers for these kind of plugins, and updates the README accordingly. Also updated a link to the documentation.

volume/shim: remove unused testVolume

sdk: remove errOnlySupportedOnLinuxAndFreeBSD, errOnlySupportedOnWindows

sdk: add TODO for systemd socket-activation

relates to https://github.com/docker/go-plugins-helpers/pull/64

It was added in 008703b825c10311af1840deeaf5f4769df7b59e, but none of the functions are exported, and none of them are currently called.

sdk: remove empty test

sdk: fix GoDoc comments, and inline variable

remove uses of deprecated io/ioutil

gha: update actions/checkout@v4

thaJeztah commented 4 months ago

Yeah, that was somewhat expected;

Pulling from library/golang
...
Digest: sha256:5f6a4662de3efc6d6bb812d02e9de3d8698eea16b8eb7281f03e6f3e8383018e
Status: Downloaded newer image for golang:1.16
+ install-deps
//go:build comment without // +build comment
make: *** [Makefile:19: install-deps] Error 1
make: *** [Makefile:15: test] Error 2
Error: Process completed with exit code 2.