search

docker / go-units

Parse and print size and time units in human-readable format
https://godoc.org/github.com/docker/go-units
Apache License 2.0
218 stars 38 forks source link

Revert 46 minute threshold #34

Closed thaJeztah closed 5 years ago

thaJeztah commented 5 years ago

This partially reverts commit 57ccf259e39e1e6d33ebc140814166820abb4c6f (https://github.com/docker/go-units/pull/22).

Using 46 minutes as a threshold proved to be confusing (see https://github.com/moby/moby/issues/38807), given that the human-duration does not use "15 minute" precision anywhere.

Before this patch, 47 minutes was shown as "About an hour". With this change, it's shown as "47 minutes".

Addresses https://github.com/moby/moby/issues/38807

thaJeztah commented 5 years ago

@vdemeester @AkihiroSuda PTAL (happy to get your input on this one)

thaJeztah commented 5 years ago

Thinking of pushing a new tag after this one (and my other PR https://github.com/docker/go-units/pull/33) is merged; WDYT; should that be v0.3.4 or v0.4.0 ?

vdemeester commented 5 years ago

I would vote for 0.4.0