search

docker / golang-cross

https://hub.docker.com/r/dockercore/golang-cross
97 stars 38 forks source link

Declare GOPROXY to disable proxy #38

Closed ndeloof closed 4 years ago

ndeloof commented 4 years ago

this is mostly to anticipate go 1.13 which will default to proxy.golang.org

see https://arslan.io/2019/08/02/why-you-should-use-a-go-module-proxy/

ndeloof commented 4 years ago

The idea is to avoid relying on https://proxy.golang.org without control on it, and override on CI/release environment with a proxy hosted within project infrastructure

vdemeester commented 4 years ago

@ndeloof My main concern is that it means the golang-cross uses a different default than Go. I would follow what is done in docker.io/library/golang, aka if the official golang image sets GOPROXY=direct, then let's do it here, if not, let's not. As you say, people can override it on CI/release env anyway :angel: (That said, I don't want to block that either :stuck_out_tongue_closed_eyes: ).

/cc @thaJeztah wdyt ?

ndeloof commented 4 years ago

Anyway I've been a bit naive here, as overriding this on CI/release will require definition of a BUILD_ARG. Let me think about this twice :)