search

docker / golang-cross

https://hub.docker.com/r/dockercore/golang-cross
97 stars 38 forks source link

Update golang to 1.13.0 #45

Closed tao12345666333 closed 4 years ago

tao12345666333 commented 5 years ago

replcace #39

tao12345666333 commented 5 years ago

I have no plan to keep this sdk file hosted there, it's just there for demonstration purpose.

Yep. We will upload it to s3.dockerproject . ๏ผˆJust because I didn't rebuild it :smile:

tao12345666333 commented 5 years ago 
Successfully tagged docker-cli-cross:latest
docker run --rm -e VERSION=19.09.0-dev -e GITCOMMIT -e PLATFORM -e TESTFLAGS -e TESTDIRS -e GOOS -e GOARCH -e GOARM -v "/builds/taobeier/golang-cross/cli":/go/src/github.com/docker/cli -v "docker-cli-dev-cache:/root/.cache/go-build"  docker-cli-cross make cross
./scripts/build/cross
Building binaries for all platforms
Generating windows resources
Building build/docker-windows-amd64
/go/src/github.com/docker/cli/scripts/gen/../winresources/common.rc:11: digit exceeds base
/go/src/github.com/docker/cli/scripts/gen/../winresources/common.rc:12: digit exceeds base
/go/src/github.com/docker/cli/scripts/gen/../winresources/common.rc:11: digit exceeds base
/go/src/github.com/docker/cli/scripts/gen/../winresources/common.rc:12: digit exceeds base
Building build/docker-darwin-amd64
Building statically linked build/docker-linux-amd64
Building statically linked build/docker-linux-arm
Building statically linked build/docker-linux-ppc64le
Building statically linked build/docker-linux-s390x

Using GitLab CI test the cli's build job. https://gitlab.com/taobeier/golang-cross/-/jobs/309123114

ndeloof commented 5 years ago

IIUC from a legal PoV we are not allowed to host sdk (derived from xcode) on a public s3, which can be considered a form of "redistribution".

tao12345666333 commented 5 years ago

I have not studied this point. I noticed that the previous sdk was hosted on S3. I also saw a similar project https://github.com/phracker/MacOSX-SDKs but I am not familiar with it.

tao12345666333 commented 5 years ago

@thaJeztah PTAL. Thanks.

tao12345666333 commented 5 years ago

ping @thaJeztah PTAL. Thanks.

cc @kolyshkin

thaJeztah commented 5 years ago

Still trying to get an answer on updating the s3 bucket; hold tight ๐Ÿ˜… Probably we should update to Go 1.13.3 now as well

ping @andrewhsu PTAL

tao12345666333 commented 5 years ago

Yep. I should update to Go 1.13.3. I am also waiting for the update of S3 bucket. :smile:

pchampio commented 4 years ago

Hey, What's the status of this PR? Awesome job btw!

tao12345666333 commented 4 years ago

wait for s3 bucket.

Jacalz commented 4 years ago

Could we please get go updated to 1.13.5 and see this merged? I can not use this package to cross compile my application as it relies on os.UserConfigDir() that was added in version 1.13...

tao12345666333 commented 4 years ago

Could we please get go updated to 1.13.5 and see this merged?

Sorry, unfortunately, if we want to merge this PR, we need a bucket to hold the SDK.

As @thaJeztah commented before https://github.com/docker/golang-cross/pull/45#issuecomment-545827442

Still trying to get an answer on updating the s3 bucket; hold tight

tao12345666333 commented 4 years ago

Update for solve conflict file.

Jacalz commented 4 years ago

It is sad that this seems to take such a long time and that the code needs to workaround using functions introduced in 1.13.0. I would be great to get this finished ๐Ÿ‘

Anyhow, while we already are waiting, could we please get the go version updated to 1.13.6 so we get all the latest fixes and security patches? ๐Ÿ™‚

tao12345666333 commented 4 years ago

@Jacalz The reason this PR has never been merged is because we don't have hostable S3 storage. https://github.com/docker/golang-cross/pull/45#issuecomment-545827442

I can update the Go version and it โ€™s easy.

pgaskin commented 4 years ago

Note that there are other images similar to this one, for example https://github.com/elastic/golang-crossbuild.

robdefeo commented 4 years ago

Any update on this?

robdefeo commented 4 years ago

@thaJeztah https://github.com/phracker/MacOSX-SDKs/releases would this not provide a drop in replacement for S3 file hosting?

tao12345666333 commented 4 years ago

@robdefeo Thanks! But I have tried it before, it is incomplete and cannot be compiled for us.

robdefeo commented 4 years ago

@tao12345666333 what are the exact requirements needed? This will help the community figure know exactly what is needed then we will be more easily able to help. Thanks

tao12345666333 commented 4 years ago

@robdefeo ref: https://github.com/phracker/MacOSX-SDKs/issues/21

Jacalz commented 4 years ago

What exactly is the problem with the bucket for storing the SDK? Is it impossible to do or have nobody stepped up with a working hosting bucket?

thaJeztah commented 4 years ago

No approval from legal to upload a new version of the SDK.

I had an alternative stashed in my local Git, that just updates the Go version, and adds some TODO comments. One restriction of that change would be that the image wouldn't set the correct "minimum version"; perhaps it doesn't cause issues, but added the comments for future follow up.

Let me open a PR for that (at least as a temporary solution)

thaJeztah commented 4 years ago

GitHub is giving angry unicorns, but managed to push https://github.com/docker/golang-cross/pull/53