docker / golang-cross

https://hub.docker.com/r/dockercore/golang-cross
97 stars 38 forks source link

bump golang 1.12.11 (CVE-2019-17596) #46

Closed thaJeztah closed 4 years ago

thaJeztah commented 4 years ago

full diff: https://github.com/golang/go/compare/go1.12.10...go1.12.11

go1.12.11 (released 2019/10/17) includes security fixes to the crypto/dsa package. See the Go 1.12.11 milestone on our issue tracker for details.

https://github.com/golang/go/issues?q=milestone%3AGo1.12.11

[security] Go 1.13.2 and Go 1.12.11 are released

Hi gophers,

We have just released Go 1.13.2 and Go 1.12.11 to address a recently reported
security issue. We recommend that all affected users update to one of these
releases (if you're not sure which, choose Go 1.13.2).

Invalid DSA public keys can cause a panic in dsa.Verify. In particular, using
crypto/x509.Verify on a crafted X.509 certificate chain can lead to a panic,
even if the certificates don't chain to a trusted root. The chain can be
delivered via a crypto/tls connection to a client, or to a server that accepts
and verifies client certificates. net/http clients can be made to crash by an
HTTPS server, while net/http servers that accept client certificates will
recover the panic and are unaffected.

Moreover, an application might crash invoking
crypto/x509.(*CertificateRequest).CheckSignature on an X.509 certificate
request, parsing a golang.org/x/crypto/openpgp Entity, or during a
golang.org/x/crypto/otr conversation. Finally, a golang.org/x/crypto/ssh client
can panic due to a malformed host key, while a server could panic if either
PublicKeyCallback accepts a malformed public key, or if IsUserAuthority accepts
a certificate with a malformed public key.

The issue is CVE-2019-17596 and Go issue golang.org/issue/34960.

Thanks to Daniel Mandragona for discovering and reporting this issue. We'd also
like to thank regilero for a previous disclosure of CVE-2019-16276.

The Go 1.13.2 release also includes a fix to the compiler that prevents improper
access to negative slice indexes in rare cases. Affected code, in which the
compiler can prove that the index is zero or negative, would have resulted in a
panic in Go 1.12, but could have led to arbitrary memory read and writes in Go
1.13 and Go 1.13.1. This is Go issue golang.org/issue/34802.
thaJeztah commented 4 years ago

ping @vdemeester @ndeloof @tao12345666333

follow up is https://github.com/docker/golang-cross/pull/47

thaJeztah commented 4 years ago

Hold on merging; looks like there was no Go 1.12.11-buster image created on Docker Hub;

docker manifest inspect golang:1.12.11-buster
no such manifest: docker.io/library/golang:1.12.11-buster
tao12345666333 commented 4 years ago

thanks for your ping.

I think we can merge #47 directly.

Xref: https://github.com/docker-library/golang/issues/307#issuecomment-543505122

Do we want to publish an cross image of 1.12.11? At least no image of 1.12.11 has been published yet.

thaJeztah commented 4 years ago

Well, probably should squash them if there's not gonna be a 1.12.11 image on hub, otherwise there's a broken commit in between 🤔

Otoh, merging it would allow creating a tag afterwards if we think it's important, so yes, we could then just merge #47

thaJeztah commented 4 years ago

Okay; let's close this one