search

docker / gordon

Cli application to manage github pull requests
MIT License
176 stars 33 forks source link

if you use commands that need the GitHub API key before you have set it, they crash #130

Closed SvenDowideit closed 10 years ago

tianon commented 10 years ago

Not very DRY, but LGTM.

SvenDowideit commented 10 years ago

@tianon yeah, I find most of golang's error checking not very DRY - but it does communicate the constraint in the place where it needs testing.

crosbymichael commented 10 years ago

Ya lets just move this check to the GetGithubUser method

erikh commented 10 years ago

Maybe just a constant for the error would work?

erikh commented 10 years ago

Carrying in #151, closing