search

docker / gordon

Cli application to manage github pull requests
MIT License
176 stars 33 forks source link

Add automated checks for two LGTM rule. #170

Open cyphar opened 8 years ago

cyphar commented 8 years ago

Both Docker and opencontainers projects have the same set of rules for merging. We should add some checks to Gordon so that it harasses maintainers who merge code without it having two LGTMs (as well as adding a comment while there are still LGTMs missing).

Preferably Gordon would also check that the isn't any self-LGTMs (opencontainers/project-template#13).

This allows us to do more management of our respective projects without needing to use a proprietary tool (PullApprove).

fkautz commented 8 years ago

So two feature requests:

These sound reasonable to me. Do you want to submit a patch for not accepting self-lgtm? Devs can always "merge --force" so it shouldn't block people on tiny projects.

For requiring multiple lgtm, we should work out a way to make this configurable. I'll spend some time thinking about how to do this. One option might be to have a .gordon config file to make this configurable. Suggestions are welcome.