docker / hub-feedback

Feedback and bug reports for the Docker Hub
https://hub.docker.com
232 stars 40 forks source link

[Docker Hub tags explorer] major display bug (for Dockerfiles using the SHELL directive) #2018

Closed erikmd closed 1 year ago

erikmd commented 4 years ago

Problem description: for images that rely on a custom SHELL (≠ /bin/sh -c), currently only the SHELL argument is displayed in the "Image history" summary in Docker Hub's tags explorer; even for directives other than RUN!

See e.g. the screenshot below taken at this URL for coqorg/base:4.05.0:

2020-07-25_23-55-47_Screenshot_Docker_Hub_tags_explorerdisplay_bug

More precisely, it comes from a Dockerfile that contains:

FROM debian:10-slim
ARG OPAM_VERSION
ENV OPAM_VERSION=${OPAM_VERSION}
SHELL ["/bin/bash", "--login", "-o", "pipefail", "-c"]
RUN cat /proc/cpuinfo /proc/meminfo \
  && [ -n "${OPAM_VERSION}" ] \
  && apt-get update -y -q \
  && DEBIAN_FRONTEND=noninteractive apt-get install -y -q --no-install-recommends \
  # more omitted…
ARG guest_uid=1000
# more omitted…

As shown by the output of the docker history command below, I guess the issue is related to the fact the current code of the webapp hardcodes the /bin/sh -c #(nop) string… while it should probably exclude all … #(nop) prefix for non-RUN directives?

$ docker history coqorg/base:4.05.0 | tail -n7
<missing>           30 minutes ago      /bin/bash --login -o pipefail -c #(nop)  ARG…   0B                  
<missing>           30 minutes ago      /bin/bash --login -o pipefail -c cat /proc/c…   290MB               
<missing>           30 minutes ago      /bin/bash --login -o pipefail -c #(nop)  SHE…   0B                  
<missing>           30 minutes ago      /bin/sh -c #(nop)  ENV OPAM_VERSION=2.0.7       0B                  
<missing>           30 minutes ago      /bin/sh -c #(nop)  ARG OPAM_VERSION             0B                  
<missing>           3 days ago          /bin/sh -c #(nop)  CMD ["bash"]                 0B                  
<missing>           3 days ago          /bin/sh -c #(nop) ADD file:6ccb3bbcc69b0d44c…   69.2MB              

Hopefully you could have a look at that somewhat distracting bug :) (the image history being otherwise not helpful at all for these images)

Thanks for your time,

erikmd commented 4 years ago

Dear Docker Hub maintainers, Do you confirm the bug from your side? − granted, it is only a "display issue", but fixing this would really be useful for previewing the content of such images.

erikmd commented 3 years ago

Cc @binman-docker (sorry to ping you directly :) but do you know if the DockerHub team has already taken a look at #2018? Hopefully the crux of the issue should be related to a regexp; but I may be wrong.

erikmd commented 3 years ago

Hello. Would you have some news regarding the status of this issue #2018?

github-actions[bot] commented 3 years ago

We are clearing up our old issues and your ticket has been open for 6 months with no activity. Remove stale label or comment or this will be closed in 15 days.

erikmd commented 3 years ago

Please keep this open, as the issue is still reproducible… updated my initial post with the last SHA256 URL example.

erikmd commented 2 years ago

Cc @justincormack @ingshtrom (sorry to ping you…😅) − would you have an ETA for this bugfix? Kind regards.

erikmd commented 1 year ago

Hi all, it seems the issue is resolved now. Thanks!