search

docker / hub-feedback

Feedback and bug reports for the Docker Hub
https://hub.docker.com
235 stars 39 forks source link

There should be a way for hooks to fail gracefully #2064

Closed JJ closed 3 years ago

JJ commented 3 years ago

Problem description

There's apparently only two possibilities in hooks. They exit with 0, and then Docker Hub proceeds to the next one, or they exit with any other value, in which case it appears as a "Failed build". It's not a big deal, but there should be a way to say "We didn't build this time just because we didn't want to". A failed build sends the wrong message to users, not to mention it actually sends the wrong message to the owner saying "Hey, this failed", when all the owner wanted is the build not to happen (for instance, if the Dockerfile has not been modified, as indicated in #403)

JJ commented 3 years ago

Additionally, the problem with these "failures" is that they don't deploy or upload the GitHub repository to the Docker Hub repo. So, for instance, if you don't want to re-generate 20 images just because you've changed the README and want the new one done. Alternatively, it would be interesting to just tell it to stop just short of creating the images, while the rest of the stuff, notably Readmes, could be deployed.

github-actions[bot] commented 3 years ago

We are clearing up our old issues and your ticket has been open for 6 months with no activity. Remove stale label or comment or this will be closed in 15 days.