docker / hub-feedback

Feedback and bug reports for the Docker Hub
https://hub.docker.com
232 stars 40 forks source link

Webhook push_data array seems incomplete, lists no images, pushes often #2148

Open JC5 opened 3 years ago

JC5 commented 3 years ago

Problem description

I build Firefly III in Azure using a script to generate multi-arch Docker images. I want to link this to my Gitter channel. However, the necessary info is missing.

Each time my script builds Firefly III, the Webhook is called six times:

{"push_data": {"pushed_at": 1631871970, "images": [], "tag": "develop", "pusher": "jc5x"}, "callback_url": "https://registry.hub.docker.com/u/fireflyiii/core/hook/2bda0e2f204fj42egeb225d5ca2fa0eb1/", "repository": {"status": "Active", "description": "Firefly III", "is_trusted": false, "full_description": "[..]", "repo_url": "https://hub.docker.com/r/fireflyiii/core", "owner": "fireflyiii", "is_official": false, "is_private": false, "name": "core", "namespace": "fireflyiii", "star_count": 10, "comment_count": 0, "date_created": 1620102244, "repo_name": "fireflyiii/core"}}

There are no images listed here. This breaks the webhook. Similar questions have been asked in the past but this a slightly different situation, I think.

As far as I can tell:

I'd appreciate some feedback on this. Am I holding it wrong?

github-actions[bot] commented 2 years ago

We are clearing up our old issues and your ticket has been open for 6 months with no activity. Remove stale label or comment or this will be closed in 15 days.

JC5 commented 2 years ago

Seriously?

ruggi commented 2 years ago

Hey @JC5 šŸ‘‹ We recently updated the documentation for the webhooks, as it was incorrectly mentioning the images field which is not part of the webhook payload data (previously it was always an empty array).

As per the six-fold webhooks payload, that's weird - are you getting six webhooks for a single push? In theory, there should be only 1 webhook being sent per push, if that's not the case there's probably a bug on our side šŸ¤”