Support for Hyperv on windows

floradu88 commented 8 years ago

Hello,

I am working on a fork on adding support for hyperv. I will probably do a pull request if thats ok?

Regards, Radu

FrenchBen commented 8 years ago

That would be great - Thanks!

floradu88 commented 8 years ago

Thanks, will try to create it tomorrow.

floradu88 commented 8 years ago

Submitted pull request with changes: https://github.com/docker/kitematic/pull/1491

FrenchBen commented 8 years ago

Yup saw it, but haven't had time to build a windows VM to do a review. Hopefully I get a bit of time towards the end of the week. One question was regarding the VM creation in HyperV, but it looks like you're using the hyperv machine driver?

floradu88 commented 8 years ago

Yes, I am trying to see if hyper-v is installed. If it is installed, then I create the machine with hyper-v. I am using the same command as for virtualbox, but with different arguments.

pmario commented 8 years ago

Hi, I managed to get my branch working. \o/.

To check if Hyper-V exists, I'm using the same command as docker-machine
kitematic can run in user mode. no "run as admin needed" .. except "create" (atm)
- user needs to be in group: Hyper-V-Administrator
creating the VM with docker-machine needs a workaround, because
- docker machine has an issue with a hard coded dependency. ... Some more testing is needed.
- MS seems to have one too. .... more testing needed.
the switch name is still hard coded, but without spaces now: DockerVirtualSwitch. No spaces simplifies the elevated command a lot. ...
The second possibility would be, to use the same mechanism as docker-machine. .. They use the first one they find and provide a config parameter to change it.
- I think we should go with this solution. ---> What do you think?
IMO the switch should be created by the User. .. we should just check if one exists and point them to the right docs, how to create one. ... We don't know the users security requirements. So let them create it.
I'll try to publish my version tomorrow.

floradu88 commented 8 years ago

Looks good. I haven't have time to do anything in the past week. But will take a look at your branch.

pmario commented 8 years ago

Link to #1161, IMO it seems to be useful code but forgotten.

pmario commented 8 years ago

Hard coded requirements

User needs to be part of the Hyper-V-Administrators group.
- User needs elevated rights only once: When VM is created.
- see: comment above point 3
The virtual switch needs to be named KitematicVirtualSwitch

Setup Kitematic VSwitch

Open the Hyper-V Manager Desktop App
If you need Internet Access, you'll probably need to use External Network!
see msdn Hyper-V on Windows for more info.

Add user to Hyper-V-Administrators group

Open your file explorer
right click This PC: Manage (You have to be Admin to do this !)
System Tools: Local Users and Groups: Groups

pmario commented 8 years ago

I can't test it with VBox. So someone should definitely see if it still works :)

docker / kitematic