search

docker / kitematic

Visual Docker Container Management on Mac & Windows
https://kitematic.com
Apache License 2.0
12.23k stars 1.41k forks source link

Add hostname aliases to the UI to support virtualhost in apache #2350

Open adamhrz opened 7 years ago

adamhrz commented 7 years ago

I have a hostname configured on my host mapping local.domain.com to 127.0.0.1 which means my container configured with virtual hosts can respond to the requests and route to the correct virtual host.

Expected behavior

I would like to be able to add a list of virtual hosts in the settings of a container in Kinematic such that I can click on the web preview to go to the site http://local.domain.com in my browser.

Actual behavior

Clicks on web preview route to http://localhost instead which is a different virtual host on the box.

FrenchBen commented 7 years ago

I'm not sure what you're trying accomplish with this? Using host mapping to have containers talk to each other isn't the ideal setup, they should be networked. If this is something to simulate going to different domains based on settings, then I would suggest that your container reads the HOST env for the domain it should redirect to.

daaru00 commented 7 years ago

What about add a setting to set -h docker run parameters?

-h, --hostname string             Container host name

or a global setting to declare local domain (es .local or .dev) and re-use container's name to set it:

<container-name>.local
FrenchBen commented 7 years ago

I don't have a lot of cycles to work on this - Feel free to create a PR showing how you'd like this to work.