docker / labs-make-runbook

Other
43 stars 5 forks source link

Start refactor to use new prompts system #38

Closed ColinMcNeil closed 15 hours ago

slimslenderslacks commented 2 weeks ago

After trying to upgrade to the new version of the extension, I'm seeing at least two immediate issues

CleanShot 2024-08-27 at 07 11 33

I'm assuming this is because all make-runbook users will have to do something to migrate here, since they both are trying to start the same LSP? Do you have to warn that having make-runbook installed is incompatible and it has to be removed?

ColinMcNeil commented 2 weeks ago

Did you uninstall the old make-runbook extension? I changed the ID so it installs as a new extension rather than an update. I already have something to warn users about incompatible versions from our previous projects. I'll add that in.

slimslenderslacks commented 2 weeks ago

Eventually, I uninstalled the previous extension because I figured out what was going wrong. But I think the warning is necessary because these two extensions are incompatible and in my case, the old extension continued working and the new one was borked.

ColinMcNeil commented 2 weeks ago

@slimslenderslacks Re-requested review specifically to make sure the extension update flow works.

Screenshot 2024-08-29 at 9 33 24 AM Screenshot 2024-08-29 at 9 34 07 AM