http2 fd too many files

[bit4bit]

hi,

i'm implementing a server with libchan and http2, they work well, but they fail after some minutes with the error fd too many files open,when debug see the descriptor for libchan.Message.Fd create by the http2.StreamReceiver.Receive method used on the server, they grow and grow.. look, simple test, ulimit -n 80 then running de server the Fd grow:

• adialer-handler2014/07/09 00:01:14 msg.Fd &{%!s(*os.file=&{9 0})}
• adialer-handler2014/07/09 00:01:15 msg.Fd &{%!s(*os.file=&{13 0})}
• adialer-handler2014/07/09 00:01:15 msg.Fd &{%!s(*os.file=&{15 0})}
• adialer-handler2014/07/09 00:01:17 msg.Fd &{%!s(*os.file=&{23 0})}
• adialer-handler2014/07/09 00:01:29 msg.Fd &{%!s(*os.file=&{29 0})}
• ...
• adialer-handler2014/07/09 00:01:34 msg.Fd &{%!s(*os.file=&{72 0})}

and boom!, i'm find a solution and it's closing the descriptor (msg.Fd.Close()) when then server finish the response,

there a better way?

thanks

[bit4bit]

not work, msg.Fd.Close() another descriptor not close :(

[pnasrat]

Do you have a pointer to the code (or a simplified reproducer of) that you have written and how you are testing?

[dmcgowan]

Work is currently being done to reduce the fds that are used. Message fd is being update to use an io.ReadWriteCloser leaving it up to caller to determine what type the byte stream will be. If you can share the code or use case as @pnasrat suggested, I think that would be helpful to ensure any changes that are being made fit your use case.

[bit4bit]

hi, found a solution, commenting the use of createAttachment in method StreamReceiver.Receiver, then all my tests works.

func (s *StreamReceiver) Receive(mode int) (*libchan.Message, error) {
                ...

                 //var attachErr error
                //attach, attachErr = createAttachment(stream)
                //if attachErr != nil {
                //      return nil, attachErr
                //}
                ret = &StreamSender{stream: stream, streamChans: s.streamChans}

                return &libchan.Message{
                        Data: data,
                        Fd:   nil,
                        Ret:  ret,
                }, nil
              ...

[dmcgowan]

This issue should be fixed with the updated libchan interface