Update channel passing to use reference ids instead of stream ids

docker / libchan

Like Go channels over the network

Apache License 2.0

2.47k stars 142 forks source link

Update channel passing to use reference ids instead of stream ids #54

Closed dmcgowan closed 9 years ago

dmcgowan commented 9 years ago

Necessary to achieve compatibility with other clients which are not using stream id directly. This also fixes the binary encoding of the stream id values to always use 4 bytes for 32bit integer values allowing for easier integration than the default go binary varint encoding.

This changes makes docker/libchan and GraftJS/jschan compatible.

Relevant to #51

dmcgowan commented 9 years ago

Rebased and unit test added

BrianBland commented 9 years ago

LGTM

dmcgowan commented 9 years ago

Thanks for the review