search

docker / libchan

Like Go channels over the network
Apache License 2.0
2.47k stars 142 forks source link

request free ports from the OS #94

Closed drewwells closed 9 years ago

drewwells commented 9 years ago

Tests were hardcoded to ports that may not be available on the system. Some ports were reused in subsequent tests which caused tests to occasionally fail when the system didn't release these ports.

dmcgowan commented 9 years ago

Yes, this change is needed. Do you think you can make the update I suggested to clean it up. Also please sign the commit according to https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work. Then I will get this merged. Thanks!

drewwells commented 9 years ago

Definitely already working on it, do I need sign every commit?

dmcgowan commented 9 years ago

Yes add the sign off to every commit

dmcgowan commented 9 years ago

LGTM, just please add sign off to first commit.

drewwells commented 9 years ago

Sorry about that, rebased to one commit with sign.

dmcgowan commented 9 years ago

Excellent! thanks LGTM