Closed iankronquist closed 8 years ago
hey @iankronquist,
Thank you for the report :wink:. You're right it fails miserably on 2 points : it did not deserialize it right (the shm_size
) and it panic where it shouldn't have..
I'll take a look at it soon, and I've added it to the next release :)
@vdemeester, actually I think the panic comes from my proof of concept code which doesn't handle errors properly so as to be as simple as possible. Thanks for the quick reply.
I tried to reproduce this issue, but it works fine at my machine. Used same libcompose code with docker 1.11.1 version.
What is your docker-engine version?
@kunalkushwaha
docker --version Docker version 1.9.1, build 78ee77d/1.9.1
I'm just using the CentOS 7 Docker package, and nothing fancy like EPEL or Docker specific repositories.
I think that is the problem. There were few significant changes in 1.10 release.
shm_size
was also added in 1.10 release.
Upgrading docker engine will fix your problem.
@kunalkushwaha I'm confused. If it doesn't exist in Docker 1.9 why would I be getting that error?
@iankronquist I guess, I misinterpreted the release notes, from 1.10, the modification of shm_size was allowed.
But yes, with 1.11 release I am not able to reproduce it. Need to dig into code, serialization of shm_size must have been fixed. I guess something like https://github.com/docker/docker/blob/14b5a50f0a95a2b8f3ed7ab7469bbab02189a09c/daemon/daemon_unix.go#L245
@iankronquist @kunalkushwaha This should be fixed on master. Do one of you want to try it out and verify your issue is no longer present?
Just tested this and it seems to be working. If anyone encounters any issues around shm_size
, please open a new issue!
A
docker-compose.yml
file errors with libcompose but succeeds withdocker-compose
. This may have to do with the handling of shm_size.libcompose commit 8ee7bcc364f7b8194581a3c6bd9fa019467c7873 (Thu May 12).
I have a simple docker-compose.yml file:
I can easily bring this up with the docker-compose command:
Great, let's try to reproduce this with libcompose:
Compile and run:
I get this ugly error: