search

docker / libcompose

*Unmaintained/Deprecated* An experimental go library providing Compose-like functionality
https://godoc.org/github.com/docker/libcompose
Apache License 2.0
585 stars 191 forks source link

Use vndr to vendor stuff #432

Closed vdemeester closed 7 years ago

vdemeester commented 7 years ago

Removing shell scripts. I'll update the image to put vndr inside so it can be used for update vendoring 👼.

Signed-off-by: Vincent Demeester vincent@sbr.pm

joshwget commented 7 years ago

+1 for moving to vendor.conf. Any change you'd consider trash though? I reference the imports for libcompose very often for other projects and it would be nice to know the vendor folders are going to be the same.

Hopefully trash and vndr will produce the same vendor folders soon, but that's another conversation :smile:

vdemeester commented 7 years ago

@joshwget I used vndr because this is the one we tend to use for projects at Docker 👼.

I reference the imports for libcompose very often for other projects and it would be nice to know the vendor folders are going to be the same. Hopefully trash and vndr will produce the same vendor folders soon, but that's another conversation 😄

What would differ 😛 ? I mean any diff in non-go files is ok I would think. Other than that, as long as both remove _test.go and non used package, I wonder what would differ, or more importantly how would it affect the downstream project ? 👼

joshwget commented 7 years ago

Yeah, I guess I don't really have a good case here other than being pretty familiar with trash already. Looks like https://github.com/golang/dep is the future anyways.

LGTM once green!