docker / libcompose

*Unmaintained/Deprecated* An experimental go library providing Compose-like functionality
https://godoc.org/github.com/docker/libcompose
Apache License 2.0
586 stars 191 forks source link

docker-compose version 2.1 (v2.1) #441

Closed vito-c closed 6 years ago

vito-c commented 7 years ago

I just changed the version from:

version: '2'
services:

to

version: '2.1'
services:

and I get the following error:

ERRO[0000] Could not parse config for project libcompose : yaml: unmarshal errors:
  line 1: cannot unmarshal !!str `2.1` into config.RawService
panic: yaml: unmarshal errors:
  line 1: cannot unmarshal !!str `2.1` into config.RawService

Are there plans to support version 2.1 in the future? There are some important features added to the compose file healthcheck and depends_on was improved.

vdemeester commented 7 years ago

@vito-c yes there is 👼 Just lagging behind quite a bit (running a little bit out of time 😅)

vito-c commented 7 years ago

I would love to help is there a branch? or does it need to be implemented from scratch?

vito-c commented 7 years ago

@vdemeester anything I can do to help?

joshwget commented 7 years ago

It sounds like the changes to depends_on aren't supported in v3 anymore (https://github.com/docker/compose/blob/master/CHANGELOG.md#compose-file-version-21-and-up). Is it worth working on this feature still?

vito-c commented 7 years ago

@joshwget backwards compatibility is important.

I'm also a little confused by the decision to drop support for depends_on and healthchecks I haven't really heard a good argument for doing so.

yelvert commented 7 years ago

+1

jwreagor commented 6 years ago

I've started working on some of this in my spare time. In order to begin the support of more compose file versions (#474, #490) I hope to continue refactoring between when the compose file is parsed and when it is validated by JSON schema. I think that should at least bump this up to '2.1'.

I'll try to post something up early to see what the original authors think. Cheers.

joyel24 commented 6 years ago

+1 for support 2.1 yml

ghost commented 6 years ago

I think we also need 2.2 schema support

donbobka commented 6 years ago

+1 version 2.3

lpalgarvio commented 6 years ago

Referencing to rancher

CpuID commented 6 years ago

Good to close thanks to https://github.com/docker/libcompose/pull/507 (I think).