search

docker / libcompose

*Unmaintained/Deprecated* An experimental go library providing Compose-like functionality
https://godoc.org/github.com/docker/libcompose
Apache License 2.0
585 stars 191 forks source link

Fix GetServiceHash failed due to false hashing #469

Closed xihan88 closed 7 years ago

xihan88 commented 7 years ago

Hashing yaml.Networks and yaml.Volumes in previous code was processed wrong. Sprintf an array of pointers by %v in default will get a string of mem addresses, which could be changing every time libcompose project up the same compose file. Therefore OutOfSync was always triggered if service had a network config.

xihan88 commented 7 years ago

Hi. Should I close this pr and sign the commit and make a new one? Very first time here :)

vdemeester commented 7 years ago

@Azure22 you should sign your commit and force push your branch :wink: no need to re-open a new one :angel:

xihan88 commented 7 years ago

@GordonTheTurtle @vdemeester Thanks for your detailed reply!!