search

docker / libcompose

*Unmaintained/Deprecated* An experimental go library providing Compose-like functionality
https://godoc.org/github.com/docker/libcompose
Apache License 2.0
585 stars 191 forks source link

parse >2.x docker-compose.yml versions (the basics) #507

Closed CpuID closed 5 years ago

CpuID commented 5 years ago

Second attempt at https://github.com/docker/libcompose/pull/497 - at a bare minimum to be able to accept files with 2.1, 2.2, etc for now, and stub out where we would put 3.x support later.

This is by no means a comprehensive implementation, but would most likely fix:

https://github.com/docker/libcompose/issues/490 https://github.com/docker/libcompose/issues/486 https://github.com/docker/libcompose/issues/474 https://github.com/docker/libcompose/issues/441

And at least error elegantly for https://github.com/docker/libcompose/issues/421 for now.

CpuID commented 5 years ago

Note: the credit for most of this goes to @cheapRoc

CpuID commented 5 years ago

This really could use test coverage around some 2.x and 3.x version numbers, I don't have the cycles to touch it today. I'll see how things go soonish.

CpuID commented 5 years ago

awesome, thx for merging so fast :)

jwreagor commented 5 years ago

Thanks @CpuID. Shame my project fell through but glad I could help here in some way.