search

docker / libkv

Distributed key/value store abstraction library
Apache License 2.0
853 stars 205 forks source link

Do not return boltdb bucket not found error #127

Closed mrjana closed 8 years ago

mrjana commented 8 years ago

While doing a boltdb operation and if the bucket is not found we should not return a boltdb specific bucket not found error because this causes leaky abstraction where in the user of libkv needs to know about boltdb and import boltdb dependencies neither of which is desirable. Replaced all the bucket not found errors with the more generic store.ErrKeyNotFound error which is more appropriate.

Signed-off-by: Jana Radhakrishnan mrjana@docker.com

abronan commented 8 years ago

Agreed, thanks @mrjana LGTM

ping @sanimej

sanimej commented 8 years ago

mrjana: Please also remove the variable definition for ErrBoltBucketNotFound. LGTM otherwise.

mrjana commented 8 years ago

@sanimej Removed and updated.