search

docker / libkv

Distributed key/value store abstraction library
Apache License 2.0
853 stars 205 forks source link

make etcd periodic member sync configurable and optional #138

Closed vikstrous closed 2 years ago

vikstrous commented 7 years ago

fix #137

vikstrous commented 7 years ago

I don't understand this test failure. Is golint master broken?

abronan commented 7 years ago

Hey @vikstrous, I no longer maintain the library but rebasing on master should do the trick.

/cc @sanimej for review and merge

bogatuadrian commented 7 years ago

@vikstrous are you planning on fixing the build?

vikstrous commented 7 years ago

I don't think I broke it. The failure seems unrelated.

Edit: Ohhh I see now that options needs to be nil checked every time... Yeah I guess I can fix that.

abronan commented 7 years ago

@vikstrous Someone needs to merge https://github.com/docker/libkv/pull/154 first and then you can rebase on top of it to fix the build.