Open vishen opened 7 years ago
Please sign your commits following these rules: https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work The easiest way to do this is to amend the last commit:
$ git clone -b "master" git@github.com:vishen/libkv.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f
Amending updates the existing PR. You DO NOT need to open a new one.
The following was not working for me because of the way libkv handles the
path
for BoltDBI would get the following error because when libkv attempts to create the BoltDB path:
mkdir : no such file or directory
- It uses https://godoc.org/path/filepath#Split which can return an empty string fordir
.This PR checks if the
dir
is not an empty string before callingos.MkdirAll(dir, 0750)
.