search

docker / libkv

Distributed key/value store abstraction library
Apache License 2.0
853 stars 205 forks source link

Add support for memo backend. #172

Open mnottale opened 7 years ago

GordonTheTurtle commented 7 years ago

Please sign your commits following these rules: https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work The easiest way to do this is to amend the last commit:

$ git clone -b "memo-backend" git@github.com:infinit/libkv.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Dimrok commented 7 years ago

Hi @mnottale.

Could you add some tests, like the other backends please (e.g. zookeeper_test, etcd_test, etc.).

Dimrok commented 7 years ago

Hi @mnottale.

seems good but could you create different PRs for each separate problems you fixed, because: