docker / libkv

Distributed key/value store abstraction library
Apache License 2.0
854 stars 205 forks source link

Fix etcd Lock bugs #186

Closed jlhawn closed 6 years ago

jlhawn commented 6 years ago
  1. Any connection errors on the first key Set attempt may cause 2 clients to think they have acquired the lock if the second set attempt succeeds.
  2. The wait loop was not checking for 'compareAndDelete' events which means that a client may never retry to set the lock key.
vieux commented 6 years ago

LGTM