search

docker / libkv

Distributed key/value store abstraction library
Apache License 2.0
854 stars 205 forks source link

configurable zookeeper logging #196

Closed jamiealquiza closed 2 years ago

jamiealquiza commented 6 years ago

Closes #195. Adds an optional Config.DisableLogging bool param to the store package. If this param is left unspecified, the existing behavior is unchanged. Explicitly declaring the field to true will suppress the underlying go-zookeeper logging (see issue).

GordonTheTurtle commented 6 years ago

Please sign your commits following these rules: https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work The easiest way to do this is to amend the last commit:

$ git clone -b "jamiealquiza/195-zk-logging" git@github.com:jamiealquiza/libkv.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.