search

docker / libkv

Distributed key/value store abstraction library
Apache License 2.0
854 stars 205 forks source link

Bump Go to 1.17.5 and start using modules #218

Closed errordeveloper closed 2 years ago

errordeveloper commented 2 years ago

This is needed for moby/moby#43075

errordeveloper commented 2 years ago

Was this to fix the vendor failure on that PR?

Yes. Just trying to address the issue with zookeeper client and it's dead camlistore.org dependency... I'm still quite confused about these. Will report back once I have a slightly clearer idea.

errordeveloper commented 2 years ago

wondering if we should start with adding (if needed) replace lines in the Moby PR

I tried, and it didn't work. I think I'll need to update this repo to use the new client, make it work and go back to Moby.

It also looks like the issue in Moby PR comes to surface when go mod tidy runs and doesn't actually matter for any other steps of the build.

thaJeztah commented 2 years ago

I tried, and it didn't work. I think I'll need to update this repo to use the new client, make it work and go back to Moby.

Gotcha; so I didn't initially notice (thanks @crazy-max) that CI wasn't running on this PR, and thought no local changes were needed (besides the go module versions)

errordeveloper commented 2 years ago

Gotcha; so I didn't initially notice (thanks @crazy-max) that CI wasn't running on this PR, and thought no local changes were needed (besides the go module versions)

I was hoping CI would run... I ran go test ./... locally, but not sure if failures I'm seeing are to do with lack of proper setup or not. I can dig into it, but I thought of trying to make switch to new ZK client first and see if the code even builds without changes or now.

crazy-max commented 2 years ago

Gotcha; so I didn't initially notice (thanks @crazy-max) that CI wasn't running on this PR, and thought no local changes were needed (besides the go module versions)

I was hoping CI would run... I ran go test ./... locally, but not sure if failures I'm seeing are to do with lack of proper setup or not. I can dig into it, but I thought of trying to make switch to new ZK client first and see if the code even builds without changes or now.

Yeah zookeeper, etcd and consul bins seems to be required.

errordeveloper commented 2 years ago

Can we re-enable Travis for this repo?

errordeveloper commented 2 years ago

Coming for now in favour of https://github.com/docker/libkv/pull/219. Switching to modules wasn't as helpful as I originally thought it might be :)