search

docker / machine

Machine management for a container-centric world
https://docs.docker.com/machine/
Apache License 2.0
6.63k stars 1.97k forks source link

Improve upgrade command #1707

Open rominirani opened 9 years ago

rominirani commented 9 years ago

Couple of things here: 1) When upgrading a machine, it occasionally fails with the following error:

C:\Users\irani_r>docker-machine upgrade dev Stopping machine to do the upgrade... Upgrading machine dev... Downloading https://github.com/boot2docker/boot2docker/releases/download/v1.8.1/boot2docker.iso to C:\Users\irani_r.docker\machine\ iso... Error removing temporary download file: remove C:\Users\irani_r.docker\machine\cache\boot2docker.iso.tmp318635659: The process cann because it is being used by another process.

Not sure, which process is using it. As a result of this, several orphaned .tmp files stay there.

2) If there are several docker-machines to upgrade, it is a bit inefficient for it to go and download the iso image for each upgrade command. Can it be consolidated to check if the iso file exists?

Environment : Windows 7

franzinc commented 8 years ago

And, why does "docker --version" after the upgrade still show the old version of docker?

thaJeztah commented 8 years ago

@franzinc docker-machine upgrade will upgrade the version of docker in the "machine", but not your local client. If you run docker version, you should see the "server" updated