Closed londoncalling closed 8 years ago
@thaJeztah Seems like a good person to have a look!
Looks like there were some changes in this repository that were not yet integrated in the unified repository; is someone able to take care of those? LGTM otherwise
diff --git a/docs/project/set-up-dev-env.md b/docs/project/set-up-dev-env.md
index e61f043..eb4ce4e 100644
--- a/docs/project/set-up-dev-env.md
+++ b/docs/project/set-up-dev-env.md
@@ -125,7 +125,7 @@ can take over 15 minutes to complete.
4. Use `make` to build a development environment image and run it in a container.
```bash
- $ make BIND_DIR=. shell
+ $ make shell
The command returns informational messages as it runs. The first build may
@@ -255,23 +255,23 @@ example, you'll edit the help for the attach
subcommand.
Your location should be different because, at least, your username is
different.
-3. Open the cli/command/container/attach.go
file.
+3. Open the api/client/attach.go
file.
Edit the command's help message.
For example, you can edit this line:
- flags.BoolVar(&opts.noStdin, "no-stdin", false, "Do not attach STDIN")
+ noStdin := cmd.Bool([]string{"-no-stdin"}, false, "Do not attach STDIN")
And change it to this:
- flags.BoolVar(&opts.noStdin, "no-stdin", false, "Do not attach STDIN (standard in)")
+ noStdin := cmd.Bool([]string{"-no-stdin"}, false, "Do not attach STDIN (standard in)")
-5. Save and close the cli/command/container/attach.go
file.
+5. Save and close the api/client/attach.go
file.
diff --git a/docs/project/software-req-win.md b/docs/project/software-req-win.md
index fb31b47..2f3d2bb 100644
--- a/docs/project/software-req-win.md
+++ b/docs/project/software-req-win.md
@@ -107,7 +107,7 @@ you use the manager to install the tar
and xz
tools from the collection.
The system displays the available packages.
-8. Click on the msys-tar bin package and choose Mark for Installation. +8. Click on the the msys-tar bin package and choose Mark for Installation.
@johndmulhausen here is the PR for this. I don't see a
maintainers
file in this repo, so not sure who else to tag.Signed-off-by: Victoria Bialas victoria.bialas@docker.com