docker / roadmap

Welcome to the Public Roadmap for All Things Docker! We welcome your ideas.
https://github.com/docker/roadmap/projects/1
Creative Commons Zero v1.0 Universal
1.47k stars 246 forks source link

Docker Desktop Dev Environments: .devcontainer.json Integration #331

Open marchesir opened 2 years ago

marchesir commented 2 years ago

Tell us about your request When DD (Docker Desktop) dev enviroment is created if .devcontainer.json allready exists it is ignored. As many git repos above all now have .devcontainer.json integration, e.g. GitHub codespaces, local vscode, cli docker. All are controlled by the .devcontainer.json file: https://code.visualstudio.com/docs/remote/devcontainerjson-reference. It would make the DD dev envirionments perfect, but when created the .devcontainer.json is ignored even if present.

Which service(s) is this request for? DD dev environments.

Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard? Im trying to use DD dev environments but id like them to be aware of pre-existing .devcontainer.json and not ignore. My objective is not to touch local, in that all tooling is isolated into containers, some in git repo others just local but DD should if .devcontainer.json found boot that config not create new based on language or default.

Are you currently working around the issue? Not sure if there is a workaround, just use vscode/docker directly and not DD dev environments which is a shame.

Additional context Used this simple repo as example: https://github.com/marchesir/learn-k8s which has this simple .devcontainer.json (https://github.com/marchesir/learn-k8s/blob/main/.devcontainer.json) but ignores it and uses its own .devcontainer.json.

dc1

dc2

btmurrell commented 1 year ago

Yes, I wonder why that would not be the obvious choice. I was quite surprised to try this feature to see that it ignored my devcontainer.json file... +100 for me. Without recognizing the devcontainer.jon file, this feature does not provide any benefit for me. i can initiate from vscode.