search

docker / scout-cli

Docker Scout CLI
https://docker.com/products/docker-scout
Other
250 stars 60 forks source link

After update of Docker Desktop (4.27.0), cant scan any local image anymore #90

Closed K2ouMais closed 4 months ago

K2ouMais commented 5 months ago

Hello everyone,

since I updated Docker Desktop to the latest version, seems that something on Docker Scout got broken, while scanning local Images.

image

Here are my versions: image image

I am using WSL2 updated to the latest pre-release.

EDIT: In Windows Powershell it seems to work: image

cdupuis commented 5 months ago

@K2ouMais thanks for reporting this. We’ll take a look immediately and report back. Sorry for the inconvenience.

rainchei commented 5 months ago

we got the same error too, here's our docker version

Client: Docker Engine - Community
 Version:           25.0.1
 API version:       1.44
 Go version:        go1.21.6
 Git commit:        29cf629
 Built:             Tue Jan 23 23:09:46 2024
 OS/Arch:           linux/amd64
 Context:           default

Server: Docker Engine - Community
 Engine:
  Version:          25.0.1
  API version:      1.44 (minimum version 1.24)
  Go version:       go1.21.6
  Git commit:       71fa3ab
  Built:            Tue Jan 23 23:09:46 2024
  OS/Arch:          linux/amd64
  Experimental:     true
 containerd:
  Version:          1.6.27
  GitCommit:        a1496014c916f9e62104b33d1bb5bd03b0858e59
 runc:
  Version:          1.1.11
  GitCommit:        v1.1.11-0-g4bccb38
 docker-init:
  Version:          0.19.0
  GitCommit:        de40ad0
cdupuis commented 5 months ago

Could you please test this again but set DOCKER_SCOUT_CACHE_FORMAT=tar?

K2ouMais commented 5 months ago

@cdupuis This seems to work.

image

thaJeztah commented 5 months ago

@cdupuis looks like possibly related to https://github.com/moby/moby/pull/44598. TL;DR the path to the blobs should be read from the manifest that's exported (which is now blobs/<algorithm>)

cat manifest.json | jq .
[
  {
    "Config": "blobs/sha256/3e4fd538a9a0b729be05707cf805388be2fb701cfd5d44c6542f1988e8aef6e3",
    "RepoTags": [
      "busybox:latest"
    ],
    "Layers": [
      "blobs/sha256/c2bf9493c1bf786e95e3eac7d406c20aa1b8a2d40916756e891627e9e8f8d119"
    ]
  }
]
cdupuis commented 5 months ago

@thaJeztah why would this only surface on WSL2?

cdupuis commented 4 months ago

This should be fixed in recent v1.4.1.