search

dockersamples / 101-tutorial

Apache License 2.0
334 stars 222 forks source link

Change container to images #11

Closed peninoule closed 4 years ago

peninoule commented 4 years ago

I saw an error in the index.md file, line 52.

The inital file was saying "... we saw that each container is effectively read-only"

I would like to change this to "... each images is effectively read-only"

Best regards peninoule

mikesir87 commented 4 years ago

Hi @peninoule and thanks for the PR and feedback! 👋

I see what you're saying, as it is a little confusing. The container itself isn't read-only, but images are. But we're trying to show that containers start from scratch each time they restart, rather than having things persist. So, maybe the best approach might be to reword that entire section, rather than a single word change. That sound ok?

peninoule commented 4 years ago

Hello Mickael,

Thanks for the answer ! :)

I see the point now !

I’m no docker expert ( just a student from Rachid Zarouali’s classes), so I’m not sure if I can really give advices to someone like you but still, your correction seems to clarify the situation and I quite like it !

Best regards, Pierre-Jean

De : Michael Irwinmailto:notifications@github.com Envoyé le :jeudi 28 novembre 2019 18:25 À : dockersamples/101-tutorialmailto:101-tutorial@noreply.github.com Cc : CROUZET Pierre-Jeanmailto:pierrejean.crouzet@ipilyon.net; Mentionmailto:mention@noreply.github.com Objet :Re: [dockersamples/101-tutorial] Change container to images (#11)

@mikesir87 commented on this pull request.

In docs_en/tutorial/persisting-our-data/index.mdhttps://github.com/dockersamples/101-tutorial/pull/11#discussion_r351887671:

@@ -49,7 +49,7 @@ What you'll see is that the files created in one container aren't available in a

Container Volumes

-With the previous experiment, we saw that each container is effectively read-only. While containers

+With the previous experiment, we saw that each images is effectively read-only. While containers

How about something like this? Thoughts? ⬇️ Suggested change

-With the previous experiment, we saw that each images is effectively read-only. While containers

+With the previous experiment, we saw that each container restarts from scratch from its image. While containers

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/dockersamples/101-tutorial/pull/11?email_source=notifications&email_token=AN3ZWZPWDS5R2XZSGGAFCU3QV75HRA5CNFSM4JRG4RRKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCNLBVSQ#pullrequestreview-324410058, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AN3ZWZJEZ5V6K2C3GXGA7BDQV75HRANCNFSM4JRG4RRA.

mikesir87 commented 4 years ago

Sorry for the delay! But no worries about not being an expert. I've been doing it for so long that I sometimes forget how much there is to learn. So, your perspective is definitely valuable here! If you think that change will work, can you accept/commit the suggestion? Then, I'll merge the PR. 👍

mikesir87 commented 4 years ago

Thanks! I've merged it and will get it built/pushed out shortly 👍